New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CUDA version checking code #2448
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use cudaRuntimeGetVersion and cudaDriverGetVersion to check the compatibility of the toolkit versions vs driver version * Prints warning messages if the driver version is not included in the CudaToDriverVersion in Debug builds. * Fix int_version_to_string function
9prady9
reviewed
Mar 3, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
"version %.2f or later. Please download and install the latest " | ||
"drivers from https://www.nvidia.com/drivers for your GPU. " | ||
"Alternatively, you could rebuild ArrayFire with CUDA Toolkit " | ||
"version %s to use the current drivers."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msg
can be moved down after if block with return statement.
9prady9
previously approved these changes
Mar 3, 2019
9prady9
approved these changes
Mar 3, 2019
9prady9
pushed a commit
to 9prady9/arrayfire
that referenced
this pull request
Mar 27, 2019
* Improve CUDA version checking code * Use cudaRuntimeGetVersion and cudaDriverGetVersion to check the compatibility of the toolkit versions vs driver version * Prints warning messages if the driver version is not included in the CudaToDriverVersion in Debug builds. * Fix int_version_to_string function * Fix warnings and format strings in platform code and tests (cherry picked from commit b89fab7)
umar456
added a commit
to 9prady9/arrayfire
that referenced
this pull request
Apr 17, 2019
* Improve CUDA version checking code * Use cudaRuntimeGetVersion and cudaDriverGetVersion to check the compatibility of the toolkit versions vs driver version * Prints warning messages if the driver version is not included in the CudaToDriverVersion in Debug builds. * Fix int_version_to_string function * Fix warnings and format strings in platform code and tests (cherry picked from commit b89fab7)
umar456
added a commit
to 9prady9/arrayfire
that referenced
this pull request
Apr 17, 2019
* Improve CUDA version checking code * Use cudaRuntimeGetVersion and cudaDriverGetVersion to check the compatibility of the toolkit versions vs driver version * Prints warning messages if the driver version is not included in the CudaToDriverVersion in Debug builds. * Fix int_version_to_string function * Fix warnings and format strings in platform code and tests (cherry picked from commit b89fab7)
umar456
added a commit
to 9prady9/arrayfire
that referenced
this pull request
Apr 17, 2019
* Improve CUDA version checking code * Use cudaRuntimeGetVersion and cudaDriverGetVersion to check the compatibility of the toolkit versions vs driver version * Prints warning messages if the driver version is not included in the CudaToDriverVersion in Debug builds. * Fix int_version_to_string function * Fix warnings and format strings in platform code and tests (cherry picked from commit b89fab7)
umar456
added a commit
that referenced
this pull request
Apr 17, 2019
* Improve CUDA version checking code * Use cudaRuntimeGetVersion and cudaDriverGetVersion to check the compatibility of the toolkit versions vs driver version * Prints warning messages if the driver version is not included in the CudaToDriverVersion in Debug builds. * Fix int_version_to_string function * Fix warnings and format strings in platform code and tests (cherry picked from commit b89fab7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compatibility of the toolkit versions vs driver version
CudaToDriverVersion in Debug builds.