Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CUDA version checking code #2448

Merged
merged 2 commits into from Mar 3, 2019
Merged

Conversation

umar456
Copy link
Member

@umar456 umar456 commented Mar 3, 2019

  • Use cudaRuntimeGetVersion and cudaDriverGetVersion to check the
    compatibility of the toolkit versions vs driver version
  • Prints warning messages if the driver version is not included in the
    CudaToDriverVersion in Debug builds.
  • Fix int_version_to_string function

* Use cudaRuntimeGetVersion and cudaDriverGetVersion to check the
  compatibility of the toolkit versions vs driver version
* Prints warning messages if the driver version is not included in the
  CudaToDriverVersion in Debug builds.
* Fix int_version_to_string function
Copy link
Member

@9prady9 9prady9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

src/backend/cuda/platform.cpp Show resolved Hide resolved
"version %.2f or later. Please download and install the latest "
"drivers from https://www.nvidia.com/drivers for your GPU. "
"Alternatively, you could rebuild ArrayFire with CUDA Toolkit "
"version %s to use the current drivers.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

msg can be moved down after if block with return statement.

9prady9
9prady9 previously approved these changes Mar 3, 2019
@9prady9 9prady9 merged commit b89fab7 into arrayfire:master Mar 3, 2019
9prady9 pushed a commit to 9prady9/arrayfire that referenced this pull request Mar 27, 2019
* Improve CUDA version checking code

* Use cudaRuntimeGetVersion and cudaDriverGetVersion to check the
  compatibility of the toolkit versions vs driver version
* Prints warning messages if the driver version is not included in the
  CudaToDriverVersion in Debug builds.
* Fix int_version_to_string function

* Fix warnings and format strings in platform code and tests

(cherry picked from commit b89fab7)
umar456 added a commit to 9prady9/arrayfire that referenced this pull request Apr 17, 2019
* Improve CUDA version checking code

* Use cudaRuntimeGetVersion and cudaDriverGetVersion to check the
  compatibility of the toolkit versions vs driver version
* Prints warning messages if the driver version is not included in the
  CudaToDriverVersion in Debug builds.
* Fix int_version_to_string function

* Fix warnings and format strings in platform code and tests

(cherry picked from commit b89fab7)
umar456 added a commit to 9prady9/arrayfire that referenced this pull request Apr 17, 2019
* Improve CUDA version checking code

* Use cudaRuntimeGetVersion and cudaDriverGetVersion to check the
  compatibility of the toolkit versions vs driver version
* Prints warning messages if the driver version is not included in the
  CudaToDriverVersion in Debug builds.
* Fix int_version_to_string function

* Fix warnings and format strings in platform code and tests

(cherry picked from commit b89fab7)
umar456 added a commit to 9prady9/arrayfire that referenced this pull request Apr 17, 2019
* Improve CUDA version checking code

* Use cudaRuntimeGetVersion and cudaDriverGetVersion to check the
  compatibility of the toolkit versions vs driver version
* Prints warning messages if the driver version is not included in the
  CudaToDriverVersion in Debug builds.
* Fix int_version_to_string function

* Fix warnings and format strings in platform code and tests

(cherry picked from commit b89fab7)
umar456 added a commit that referenced this pull request Apr 17, 2019
* Improve CUDA version checking code

* Use cudaRuntimeGetVersion and cudaDriverGetVersion to check the
  compatibility of the toolkit versions vs driver version
* Prints warning messages if the driver version is not included in the
  CudaToDriverVersion in Debug builds.
* Fix int_version_to_string function

* Fix warnings and format strings in platform code and tests

(cherry picked from commit b89fab7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants