New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix af::array::array_proxy move assignment operator #2479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9prady9
force-pushed
the
fix_array_proxy_bug
branch
from
April 2, 2019 08:01
87373d5
to
d53317e
Compare
9prady9
changed the title
Nullify move-from resource of array_proxy objects
Fix af::array::array_proxy move assignment operator
Apr 2, 2019
move assignment operator of array_proxy wasn't doing couple of things correctly. * releasing existing * nullifying the move-from objects pointer This resulted in double-free
9prady9
force-pushed
the
fix_array_proxy_bug
branch
from
April 8, 2019 03:40
d53317e
to
3aa0125
Compare
The test added fails with address sanitizer and randomly without sanitizer. Output with the sanitizer is as follows.
After the fix, given below is the expected output.
The alias to test suite |
umar456
approved these changes
Apr 8, 2019
9prady9
added a commit
to 9prady9/arrayfire
that referenced
this pull request
Apr 8, 2019
* Fix af::array::array_proxy move assignment operator move assignment operator of array_proxy wasn't doing couple of things correctly. * releasing existing * nullifying the move-from objects pointer This resulted in double-free * Unit test for double-free issue of proxy &&= operator * Minor changes to array death test & windows fixes (cherry picked from commit 1936937)
umar456
pushed a commit
to 9prady9/arrayfire
that referenced
this pull request
Apr 17, 2019
* Fix af::array::array_proxy move assignment operator move assignment operator of array_proxy wasn't doing couple of things correctly. * releasing existing * nullifying the move-from objects pointer This resulted in double-free * Unit test for double-free issue of proxy &&= operator * Minor changes to array death test & windows fixes (cherry picked from commit 1936937)
umar456
pushed a commit
to 9prady9/arrayfire
that referenced
this pull request
Apr 17, 2019
* Fix af::array::array_proxy move assignment operator move assignment operator of array_proxy wasn't doing couple of things correctly. * releasing existing * nullifying the move-from objects pointer This resulted in double-free * Unit test for double-free issue of proxy &&= operator * Minor changes to array death test & windows fixes (cherry picked from commit 1936937)
umar456
pushed a commit
to 9prady9/arrayfire
that referenced
this pull request
Apr 17, 2019
* Fix af::array::array_proxy move assignment operator move assignment operator of array_proxy wasn't doing couple of things correctly. * releasing existing * nullifying the move-from objects pointer This resulted in double-free * Unit test for double-free issue of proxy &&= operator * Minor changes to array death test & windows fixes (cherry picked from commit 1936937)
umar456
pushed a commit
that referenced
this pull request
Apr 17, 2019
* Fix af::array::array_proxy move assignment operator move assignment operator of array_proxy wasn't doing couple of things correctly. * releasing existing * nullifying the move-from objects pointer This resulted in double-free * Unit test for double-free issue of proxy &&= operator * Minor changes to array death test & windows fixes (cherry picked from commit 1936937)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move assignment operator of array_proxy wasn't doing couple of
things correctly.
This resulted in double-free