From 2964e1c590d3db37d59a7f36ee6b5a4e91485b5c Mon Sep 17 00:00:00 2001
From: Johnu George <johnugeorge109@gmail.com>
Date: Thu, 10 Oct 2019 09:08:53 +0530
Subject: [PATCH] Minor changes to Katib manifests (#457)

* Adding PeriodSeconds to livenessProbe

* Add tests

* Adding extra kubectl output
---
 katib/katib-controller/base/katib-manager-deployment.yaml | 2 ++
 katib/katib-crds/base/trial-crd.yaml                      | 3 +++
 tests/katib-controller-base_test.go                       | 2 ++
 tests/katib-controller-overlays-application_test.go       | 2 ++
 tests/katib-controller-overlays-istio_test.go             | 2 ++
 tests/katib-crds-base_test.go                             | 3 +++
 6 files changed, 14 insertions(+)

diff --git a/katib/katib-controller/base/katib-manager-deployment.yaml b/katib/katib-controller/base/katib-manager-deployment.yaml
index f153ebf2c26..27ed68ba2fe 100644
--- a/katib/katib-controller/base/katib-manager-deployment.yaml
+++ b/katib/katib-controller/base/katib-manager-deployment.yaml
@@ -43,3 +43,5 @@ spec:
           exec:
             command: ["/bin/grpc_health_probe", "-addr=:6789"]
           initialDelaySeconds: 10
+          periodSeconds: 60
+          failureThreshold: 5
diff --git a/katib/katib-crds/base/trial-crd.yaml b/katib/katib-crds/base/trial-crd.yaml
index 27e3cae0246..f7cea34064f 100644
--- a/katib/katib-crds/base/trial-crd.yaml
+++ b/katib/katib-crds/base/trial-crd.yaml
@@ -5,6 +5,9 @@ metadata:
 spec:
   additionalPrinterColumns:
   - JSONPath: .status.conditions[-1:].type
+    name: Type
+    type: string
+  - JSONPath: .status.conditions[-1:].status
     name: Status
     type: string
   - JSONPath: .metadata.creationTimestamp
diff --git a/tests/katib-controller-base_test.go b/tests/katib-controller-base_test.go
index 4db456ff18c..ced5c3e9cca 100644
--- a/tests/katib-controller-base_test.go
+++ b/tests/katib-controller-base_test.go
@@ -405,6 +405,8 @@ spec:
           exec:
             command: ["/bin/grpc_health_probe", "-addr=:6789"]
           initialDelaySeconds: 10
+          periodSeconds: 60
+          failureThreshold: 5
 `)
 	th.writeF("/manifests/katib/katib-controller/base/katib-manager-rest-deployment.yaml", `
 apiVersion: apps/v1
diff --git a/tests/katib-controller-overlays-application_test.go b/tests/katib-controller-overlays-application_test.go
index cdb795e974e..4b494fad1bf 100644
--- a/tests/katib-controller-overlays-application_test.go
+++ b/tests/katib-controller-overlays-application_test.go
@@ -484,6 +484,8 @@ spec:
           exec:
             command: ["/bin/grpc_health_probe", "-addr=:6789"]
           initialDelaySeconds: 10
+          periodSeconds: 60
+          failureThreshold: 5
 `)
 	th.writeF("/manifests/katib/katib-controller/base/katib-manager-rest-deployment.yaml", `
 apiVersion: apps/v1
diff --git a/tests/katib-controller-overlays-istio_test.go b/tests/katib-controller-overlays-istio_test.go
index 92b4ed6375d..fd8a0eb6382 100644
--- a/tests/katib-controller-overlays-istio_test.go
+++ b/tests/katib-controller-overlays-istio_test.go
@@ -442,6 +442,8 @@ spec:
           exec:
             command: ["/bin/grpc_health_probe", "-addr=:6789"]
           initialDelaySeconds: 10
+          periodSeconds: 60
+          failureThreshold: 5
 `)
 	th.writeF("/manifests/katib/katib-controller/base/katib-manager-rest-deployment.yaml", `
 apiVersion: apps/v1
diff --git a/tests/katib-crds-base_test.go b/tests/katib-crds-base_test.go
index 39f75c40438..beb238dd44a 100644
--- a/tests/katib-crds-base_test.go
+++ b/tests/katib-crds-base_test.go
@@ -85,6 +85,9 @@ metadata:
 spec:
   additionalPrinterColumns:
   - JSONPath: .status.conditions[-1:].type
+    name: Type
+    type: string
+  - JSONPath: .status.conditions[-1:].status
     name: Status
     type: string
   - JSONPath: .metadata.creationTimestamp