Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Fixes NPE in bindWithFilter #134

Merged
merged 6 commits into from May 29, 2020
Merged

Fixes NPE in bindWithFilter #134

merged 6 commits into from May 29, 2020

Conversation

aballano
Copy link
Member

@aballano aballano commented May 29, 2020 •
edited

Fixes #132

  • Change MonadFilterLaws to use a gen to test bindWithFilter in order to generate all possible values
  • Fix bindWithFilter by filtering first, then binding (thanks to @nomisRev)

@aballano aballano marked this pull request as ready for review May 29, 2020 14:12
@aballano aballano changed the title NPE in bindWithFilter Fixes NPE in bindWithFilter May 29, 2020
@aballano aballano modified the milestone: 0.11.0 May 29, 2020
@aballano aballano requested a review from nomisRev May 29, 2020 14:32
danimontoya
danimontoya approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@danimontoya danimontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🙌

@aballano aballano merged commit 5ae4cfa into master May 29, 2020
@aballano aballano deleted the ab/fix-bindWithFilter-for-list branch May 29, 2020 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danimontoya danimontoya danimontoya approved these changes

@nomisRev nomisRev Awaiting requested review from nomisRev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

["Request"] Fix NPE in bindWithFilter
2 participants
@aballano @danimontoya