Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow `NonFatal` control over exceptions for MonadError and Monadic comprehensions #153

Closed
raulraja opened this Issue Jul 26, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@raulraja
Copy link
Member

raulraja commented Jul 26, 2017

Currently comprehending over Try in an stack unsafe way returns a Failures(SOE) we should never capture fatal exceptions. See for reference http://www.scala-lang.org/api/2.12.0/scala/util/control/NonFatal$.html

@raulraja raulraja added the bug label Jul 26, 2017

@pakoito

This comment has been minimized.

Copy link
Member

pakoito commented Jul 26, 2017

RxJava does it using a set of exception subtypes for which exceptions are always propagated: SO, OOM... we should look into them.

@kartoffelsup

This comment has been minimized.

@raulraja

This comment has been minimized.

Copy link
Member Author

raulraja commented Feb 16, 2019

yep, those are a subset of the Fatal errors we need to contemplate.

kartoffelsup added a commit to kartoffelsup/arrow that referenced this issue Feb 16, 2019

kartoffelsup added a commit to kartoffelsup/arrow that referenced this issue Feb 16, 2019

kartoffelsup added a commit to kartoffelsup/arrow that referenced this issue Feb 16, 2019

kartoffelsup added a commit to kartoffelsup/arrow that referenced this issue Feb 17, 2019

kartoffelsup added a commit to kartoffelsup/arrow that referenced this issue Feb 17, 2019

kartoffelsup added a commit to kartoffelsup/arrow that referenced this issue Feb 17, 2019

kartoffelsup added a commit to kartoffelsup/arrow that referenced this issue Feb 17, 2019

kartoffelsup added a commit to kartoffelsup/arrow that referenced this issue Feb 17, 2019

raulraja added a commit that referenced this issue Feb 19, 2019

[#153] Control NonFatal Throwables (#1305)
* [#153] Port NonFatal from Scala

* [#153] MonadError Laws for Fatal and NonFatal Throwables, KDoc for NonFatal Object

* [#153] Fix `nonFatalOrThrow` Sample

* [#153] Remove `@documented` from NonFatal Object

* [#153] Remove unused imports

* [#153] Annotate code samples which are supposed to fail with ank:fail

* [#153] Delete leftover snippets from copy-pasting in NonFatal KDocs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.