New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated main dependencies and Gradle #1008
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1008 +/- ##
============================================
+ Coverage 47.03% 47.76% +0.72%
Complexity 694 694
============================================
Files 320 320
Lines 8091 8091
Branches 848 753 -95
============================================
+ Hits 3806 3865 +59
Misses 3942 3942
+ Partials 343 284 -59
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks green to me
kotlinxCoroutinesVersion = '0.23.3' | ||
kotlinVersion = '1.2.61' | ||
daggerVersion = '2.17' | ||
kotlinxCoroutinesVersion = '0.24.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're at 25 now, no biggie :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pakoito I commented about that on the PR description. That one does not work on current Android versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: read the bloody descriptions
We should regenerate and commit the latest wrapper too |
@pakoito It has the latest wrapper too. And they don't always change it on new Gradle versions. |
Note to self: read the bloody diffs too. Good job @jrgonzalezg ! |
I noticed that Arrow was still using the deprecated
kotlin-stdlib-jre7
instead ofkotlin-stdlib-jdk7
inarrow-generic
which led to compiler warnings. So I took the time to fix that and update Gradle and some of the other dependencies. I also extracted some shared dependency versions to constants on the main build.gradle together with the other constants there. And I did not update kotlinx coroutines to the very last version due to not being sure if it will work on Android due to this issue: Kotlin/kotlinx.coroutines#510