Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated main dependencies and Gradle #1008

Merged
merged 1 commit into from Sep 3, 2018

Conversation

jrgonzalezg
Copy link
Member

I noticed that Arrow was still using the deprecated kotlin-stdlib-jre7 instead of kotlin-stdlib-jdk7 in arrow-generic which led to compiler warnings. So I took the time to fix that and update Gradle and some of the other dependencies. I also extracted some shared dependency versions to constants on the main build.gradle together with the other constants there. And I did not update kotlinx coroutines to the very last version due to not being sure if it will work on Android due to this issue: Kotlin/kotlinx.coroutines#510

@jrgonzalezg jrgonzalezg self-assigned this Sep 3, 2018
@codecov
Copy link

codecov bot commented Sep 3, 2018

Codecov Report

Merging #1008 into master will increase coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1008      +/-   ##
============================================
+ Coverage     47.03%   47.76%   +0.72%     
  Complexity      694      694              
============================================
  Files           320      320              
  Lines          8091     8091              
  Branches        848      753      -95     
============================================
+ Hits           3806     3865      +59     
  Misses         3942     3942              
+ Partials        343      284      -59
Impacted Files Coverage Δ Complexity Δ
...core/arrow-core/src/main/kotlin/arrow/core/Eval.kt 81.37% <0%> (+0.98%) 8% <0%> (ø) ⬇️
...arrow-optics/src/main/kotlin/arrow/optics/Prism.kt 61.9% <0%> (+1.19%) 0% <0%> (ø) ⬇️
...arrow-data/src/main/kotlin/arrow/data/Validated.kt 71.62% <0%> (+1.35%) 23% <0%> (ø) ⬇️
...cts-rx2/src/main/kotlin/arrow/effects/FlowableK.kt 55.4% <0%> (+1.35%) 9% <0%> (ø) ⬇️
...re/arrow-core/src/main/kotlin/arrow/core/Option.kt 64.4% <0%> (+1.69%) 22% <0%> (ø) ⬇️
...es-data/src/main/kotlin/arrow/instances/eithert.kt 63.63% <0%> (+1.81%) 0% <0%> (ø) ⬇️
...e/arrow-data/src/main/kotlin/arrow/data/OptionT.kt 61.53% <0%> (+1.92%) 10% <0%> (ø) ⬇️
...e/arrow-data/src/main/kotlin/arrow/data/WriterT.kt 49.01% <0%> (+1.96%) 7% <0%> (ø) ⬇️
...cts-reactor/src/main/kotlin/arrow/effects/FluxK.kt 70.21% <0%> (+2.12%) 9% <0%> (ø) ⬇️
...s-rx2/src/main/kotlin/arrow/effects/ObservableK.kt 70.21% <0%> (+2.12%) 9% <0%> (ø) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f0c3c0...3892511. Read the comment docs.

Copy link
Member

@pakoito pakoito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks green to me

@pakoito pakoito merged commit 0d50bad into master Sep 3, 2018
@pakoito pakoito deleted the jrgonzalezg/update-dependencies branch September 3, 2018 19:22
kotlinxCoroutinesVersion = '0.23.3'
kotlinVersion = '1.2.61'
daggerVersion = '2.17'
kotlinxCoroutinesVersion = '0.24.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're at 25 now, no biggie :P

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pakoito I commented about that on the PR description. That one does not work on current Android versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: read the bloody descriptions

@pakoito
Copy link
Member

pakoito commented Sep 3, 2018

We should regenerate and commit the latest wrapper too

@jrgonzalezg
Copy link
Member Author

jrgonzalezg commented Sep 3, 2018

@pakoito It has the latest wrapper too. And they don't always change it on new Gradle versions.

@pakoito
Copy link
Member

pakoito commented Sep 3, 2018

Note to self: read the bloody diffs too. Good job @jrgonzalezg !

@raulraja raulraja mentioned this pull request Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants