New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kotlinx.coroutines to 1.0.0 #1100

Merged
merged 14 commits into from Nov 11, 2018

Conversation

Projects
None yet
2 participants
@pakoito
Member

pakoito commented Nov 10, 2018

This PR includes the changes required to support CoroutineScope in a reasonable way, plus a fix for the new exception wrapping behavior.

@pakoito pakoito requested a review from raulraja Nov 10, 2018

@pakoito pakoito requested review from JorgeCastilloPrz, nomisRev and arrow-kt/maintainers Nov 10, 2018

pakoito added some commits Nov 10, 2018

@raulraja

This comment has been minimized.

Member

raulraja commented Nov 10, 2018

@pakoito

import arrow.effects.*
import kotlinx.coroutines.async

val asyncBalance: DeferredK<Int> = async { 1000 }.k()
val asyncAvailable: DeferredK<Int> = async { 900 }.k()

ForDeferredK extensions { 
  mapToAccount(asyncBalance, asyncAvailable)
}

�[31mjava.lang.IllegalAccessError: tried to access field kotlinx.coroutines.Dispatchers.Default from class kotlinx.coroutines.DeferredKt
at kotlinx.coroutines.DeferredKt.async$default(Deferred.kt:173)�[0m

Task :arrow-docs:runAnk FAILED

pakoito added some commits Nov 11, 2018

@codecov

This comment has been minimized.

codecov bot commented Nov 11, 2018

Codecov Report

Merging #1100 into master will increase coverage by 0.03%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1100      +/-   ##
============================================
+ Coverage     42.28%   42.31%   +0.03%     
  Complexity      755      755              
============================================
  Files           365      365              
  Lines         10219    10220       +1     
  Branches       1147     1146       -1     
============================================
+ Hits           4321     4325       +4     
+ Misses         5562     5560       -2     
+ Partials        336      335       -1
Impacted Files Coverage Δ Complexity Δ
...rc/main/kotlin/arrow/effects/DeferredKInstances.kt 69.56% <50%> (ø) 0 <0> (ø) ⬇️
...outines/src/main/kotlin/arrow/effects/DeferredK.kt 63.15% <58.33%> (+6.01%) 5 <3> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 183f038...c79929c. Read the comment docs.

@pakoito pakoito merged commit 1472fa5 into master Nov 11, 2018

4 checks passed

codecov/patch 57.14% of diff hit (target 42.28%)
Details
codecov/project 42.31% (+0.03%) compared to 183f038
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@pakoito pakoito deleted the paco-coroutinesonezero branch Nov 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment