New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Async #1198

Merged
merged 72 commits into from Dec 29, 2018

Conversation

Projects
None yet
4 participants
@nomisRev
Copy link
Member

nomisRev commented Dec 13, 2018

A couple of things missing from Async are added here such as asyncF, cancellable, cancellableF and shift which also adds default implementation for continueOn.

cancellable belongs in Async but the laws require Concurrent to properly test it. Thoughts? Should I just add some tests using concrete types?

JorgeCastilloPrz and others added some commits Nov 22, 2018

Merge remote-tracking branch 'origin/master' into asyncF
# Conflicts:
#	modules/core/arrow-data/src/main/kotlin/arrow/data/EitherT.kt
#	modules/core/arrow-data/src/main/kotlin/arrow/data/Kleisli.kt
#	modules/core/arrow-data/src/main/kotlin/arrow/data/WriterT.kt
#	modules/core/arrow-data/src/test/kotlin/arrow/data/EitherTTest.kt
#	modules/core/arrow-data/src/test/kotlin/arrow/data/OptionTTest.kt
#	modules/core/arrow-data/src/test/kotlin/arrow/data/StateTTests.kt
#	modules/core/arrow-data/src/test/kotlin/arrow/data/WriterTTest.kt
#	modules/core/arrow-instances-data/src/main/kotlin/arrow/instances/eithert.kt
#	modules/core/arrow-instances-data/src/main/kotlin/arrow/instances/optiont.kt
#	modules/core/arrow-instances-data/src/main/kotlin/arrow/instances/statet.kt
#	modules/core/arrow-instances-data/src/main/kotlin/arrow/instances/writert.kt
#	modules/dagger/arrow-dagger/src/main/kotlin/arrow/dagger/instances/eithert.kt
#	modules/dagger/arrow-dagger/src/main/kotlin/arrow/dagger/instances/optiont.kt
#	modules/dagger/arrow-dagger/src/main/kotlin/arrow/dagger/instances/writert.kt
#	modules/effects/arrow-data-instances-effects/src/main/kotlin/arrow/instances/eithert.kt
#	modules/effects/arrow-data-instances-effects/src/main/kotlin/arrow/instances/kleisli.kt
#	modules/effects/arrow-data-instances-effects/src/main/kotlin/arrow/instances/optiont.kt
#	modules/effects/arrow-data-instances-effects/src/main/kotlin/arrow/instances/statet.kt
#	modules/effects/arrow-data-instances-effects/src/main/kotlin/arrow/instances/writert.kt

nomisRev and others added some commits Dec 15, 2018

nomisRev added some commits Dec 28, 2018

@raulraja raulraja merged commit 824fd46 into master Dec 29, 2018

4 checks passed

ci/bitrise/b4ac6a91e50a5bdd/pr Passed - arrow
Details
ci/bitrise/b4ac6a91e50a5bdd/push Passed - arrow
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@raulraja raulraja deleted the 1124-jc-asyncF branch Dec 29, 2018

@raulraja

This comment has been minimized.

Copy link
Member

raulraja commented Dec 29, 2018

🎉 👏

@JorgeCastilloPrz

This comment has been minimized.

Copy link
Member

JorgeCastilloPrz commented Dec 29, 2018

Awesome job Simon 👏👏

@nomisRev

This comment has been minimized.

Copy link
Member

nomisRev commented Dec 29, 2018

Thanks :)

@nomisRev nomisRev referenced this pull request Dec 29, 2018

Closed

Async.asyncF #1124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment