Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Either doc in Russian #1293

Merged
merged 6 commits into from Feb 10, 2019
Merged

Added Either doc in Russian #1293

merged 6 commits into from Feb 10, 2019

Conversation

dobrowins
Copy link
Contributor

@dobrowins dobrowins commented Feb 8, 2019 •
edited

  1. Added Russian translation of Either class
  2. Moved Try's translation to respective folder. So anyone who want to contribute would be redirected to proper page after clicking «Edit» button in the header.

pakoito
pakoito approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@pakoito pakoito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't proofread it :trollface:

@pakoito
Copy link
Member

pakoito commented Feb 9, 2019

Tell us when it's not WIP anymore so we can merge!

@dobrowins dobrowins changed the title [WIP] Added Either doc in Russian Added Either doc in Russian Feb 10, 2019
@dobrowins
Copy link
Contributor Author

Tell us when it's not WIP anymore so we can merge!

Dear @pakoito I've removed an WIP status from the PR.
Translation is correct. I've checked the links. All seems fine.

@pakoito pakoito merged commit 40ae94a into arrow-kt:master Feb 10, 2019
@pakoito
Copy link
Member

pakoito commented Feb 10, 2019

Into the repo it goes then! Thank you :D

@dobrowins dobrowins deleted the ad-either-docs-russian branch February 10, 2019 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakoito pakoito pakoito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dobrowins @pakoito