-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reactor Integration #706
Reactor Integration #706
Conversation
@Cotel Looking good so far!, let us know when this is ready for final review. |
…kt/arrow into cotel-reactor-integration
Just curious, will there also be support for |
@sbuettner I'm working on |
@Cotel Thats cool, thanks for response. |
Ping someone when this is ready for review, you may have to change stuff around once you sync with master |
…-reactor-integration # Conflicts: # settings.gradle.kts
@Cotel ping us when it's ready for review! |
ApplicativeErrorLaws.laws(MonoK.applicativeError(), EQ(), EQ(), EQ()), | ||
MonadSuspendLaws.laws(MonoK.monadDefer(), EQ(), EQ(), EQ()), | ||
AsyncLaws.laws(MonoK.async(), EQ(), EQ(), EQ()), | ||
AsyncLaws.laws(MonoK.effect(), EQ(), EQ()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These laws are duplicated. AsyncLaws implies the other typeclass laws are checked too. And our typeclasses inherit from one another so we're safe. Basically, do the same as FluxK in here :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the tests before merging! Everything else, good job.
I would also consider adding some docs, even if it's just a copypaste from Rx.
MonadSuspendLaws.laws(MonoK.monadDefer(), EQ(), EQ(), EQ()), | ||
AsyncLaws.laws(MonoK.async(), EQ(), EQ(), EQ()), | ||
AsyncLaws.laws(MonoK.effect(), EQ(), EQ()) | ||
AsyncLaws.laws(MonoK.async(), EQ(), EQ()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. You need the Traverse laws too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MonoK has no instance for Traverse and SingleK does not have it either 🤔 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okey dokey then! :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved and cheers for the docs. Please add the missing test, and ready to merge afterwards!
@@ -56,6 +56,7 @@ dependencies { | |||
compile 'io.arrow-kt:arrow-mtl:0.7.2' //optional | |||
compile 'io.arrow-kt:arrow-effects:0.7.2' //optional | |||
compile 'io.arrow-kt:arrow-effects-rx2:0.7.2' //optional | |||
compile 'io.arrow-kt:arrow-effects-reactor:0.7.2' //optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to add this line to the README in the root of the repo. It isn't the same as this one, sadly.
Nnnnnnice, good work :D |
* Starting Reactor integration * Adding some tests * Adding instances for MonoK * Including arrow-effects-reactor in settings.gradle * Updating FluxK * Updating MonoK * Fixing tests * Adding another test for FluxK * Adding tests for MonoK * Removing duplicated laws for MonoK * Adding docs for reactor integration * Including missing dependencies * Fixing typo in package name * Adding reactor dependency line to the root README
Integration with http://projectreactor.io/
Still WIP