Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw TypeError when passing booleans to arrow.get #259

Merged
merged 1 commit into from Nov 17, 2016

Conversation

@EvanHahn
Copy link
Contributor

@EvanHahn EvanHahn commented Aug 20, 2015

Before:

>>> arrow.get(False)
<Arrow [1970-01-01T00:00:00+00:00]>

>>> arrow.get(True)
<Arrow [1970-01-01T00:00:01+00:00]>

After:

>>> arrow.get(False)
TypeError: Can't parse single argument type of '<type 'bool'>'

>>> arrow.get(True)
TypeError: Can't parse single argument type of '<type 'bool'>'

Closes #238.

Before:

>>> arrow.get(False)
<Arrow [1970-01-01T00:00:00+00:00]>

>>> arrow.get(True)
<Arrow [1970-01-01T00:00:01+00:00]>

After:

>>> arrow.get(False)
TypeError: Can't parse single argument type of '<type 'bool'>'

>>> arrow.get(True)
TypeError: Can't parse single argument type of '<type 'bool'>'
@EvanHahn
Copy link
Contributor Author

@EvanHahn EvanHahn commented Mar 18, 2016

Any updates on this? No problem if not.

@andrewelkins andrewelkins merged commit 4d31d9a into arrow-py:master Nov 17, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@EvanHahn EvanHahn deleted the EvanHahn:fix-238 branch Nov 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.