Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italic variant (and possibly bold) are not being detected by Windows applications #373

Closed
javlaks opened this issue Aug 5, 2020 · 8 comments
Closed

Comments

@javlaks
Copy link

@javlaks javlaks commented Aug 5, 2020

Problem description
The italic variant is not being detected by windows applications. When I or the editor make italic, the regular font is being transformed to Italic instead of take Italic font variant

Expected behavior
Windows applications need to use the Italic variant instead of create italic from regular font

Screenshots
Here you can see from word document (right), and how should be showed (left)
image

Same case using Dank Mono, this is displaying correctly using the italic font variant
image

Not only in word, this happend in most of windows applications, here two examples from Notepad++

Rec Mono Duotone
image

Dank Mono
image

To Reproduce
Just make italic text on any windows application text editor or programming editor

Environment
OS: Windows 10 v1909
Font: 1.055
Notepad++: 7.8.4
Microsoft Word: 365 Version (16.0)

Additional information
This issue is not present in Visual Studio Code 1.47.3
image

@iansan5653
Copy link

@iansan5653 iansan5653 commented Aug 6, 2020

I'm seeing this in Intellij on Windows. Code Linear works fine, but not Code Duotone.

@arrowtype
Copy link
Owner

@arrowtype arrowtype commented Aug 6, 2020

Hmm, that is odd. Thanks for the report, @javlaks!

The fix isn’t immediately clear to me, though I’ll try to keep an eye out for a solution.

In the near term, I recommend using the normal Recursive Mono fonts in apps that are for design and general word processing. These seem to work well for me in Windows. Here’s Wordpad:

image

@iansan5653
Copy link

@iansan5653 iansan5653 commented Aug 6, 2020

@arrowtype While the first two screenshots were from Word, we're also seeing this when using code fonts in the Notepad++ and IntelliJ code editors.

@arrowtype
Copy link
Owner

@arrowtype arrowtype commented Aug 6, 2020

@javlaks okay, I may have solved this. Would you be willing to confirm with one of the families at https://github.com/arrowtype/recursive/tree/7beedaff5200a5c8000711bc92dfbeb418af94c3/fonts/rec_mono-for-code?

image

I found that I needed to set a few values for Bold, Italic, & Bold Italic fonts:

  1. In the OS/2 table, Panose bLetterform must be set to 11, for oblique fonts
  2. In the OS/2 table, the fsSelection needed to be set to italic/bold/bolditalic
  3. In the head table, the macStyle needed to be set italic/bold/bolditalic (probably not relavent to Windows, but related to the overall issue)

I think this might solve the issues in most Windows apps, and maybe even in IntelliJ. 🤞

@iansan5653 if you would be willing to try one of the updated families in IntelliJ, that would also be super helpful!

@javlaks
Copy link
Author

@javlaks javlaks commented Aug 6, 2020

Hey @arrowtype you're super fast!

It is working now :P

Wordpad
image

Notepad++
image

Netbeans
image

We only have pending a fix for the ligatures ( #369 )

Thank you for the hark work and the font ;)

@arrowtype
Copy link
Owner

@arrowtype arrowtype commented Aug 6, 2020

Yeeeeah thanks for helping to check that so quickly, @javlaks! 💪

I’ll wait to see whether @iansan5653 can check out things in IntelliJ before closing this / possibly moving that to a new issue.

@iansan5653
Copy link

@iansan5653 iansan5653 commented Aug 7, 2020

Sorry for the delay - I tried in IntelliJ and it's working! Thanks.

@arrowtype
Copy link
Owner

@arrowtype arrowtype commented Aug 8, 2020

Awesome, thanks so much for taking a look, @iansan5653!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants