Skip to content

Commit

Permalink
Fix Issue #5, 2013-12-08 "Binky" compatibilty issue (un-saveable config)
Browse files Browse the repository at this point in the history
All onoff configuration switches do not get saved when the user changes
the value. The reason was that I used true|false for "onoff" switches
although only 1|0 was allowed [1] (never noticed this).

It worked for years but the way the configuration gets parsed by DokuWiki
was changed [2] [3] after Binky RC2, so the bug affects the current
DokuWiki Binky final only.

[1] <https://www.dokuwiki.org/config#configuration_options>
[2] <dokuwiki/dokuwiki@43e7001>
[3] <http://www.freelists.org/post/dokuwiki/SemiUrgent-broken-template-config-in-final-Binky,1>
  • Loading branch information
andreashaerter committed Feb 8, 2014
1 parent 9de0850 commit 73263c1
Showing 1 changed file with 18 additions and 22 deletions.
40 changes: 18 additions & 22 deletions conf/default.php
Original file line number Diff line number Diff line change
Expand Up @@ -33,43 +33,43 @@
}

//user pages
$conf["monobook_userpage"] = true; //TRUE: use/show user pages
$conf["monobook_userpage"] = 1; //1: use/show user pages
$conf["monobook_userpage_ns"] = ":wiki:user:"; //namespace to use for user page storage

//discussion pages
$conf["monobook_discuss"] = true; //TRUE: use/show discussion pages
$conf["monobook_discuss"] = 1; //1: use/show discussion pages
$conf["monobook_discuss_ns"] = ":talk:"; //namespace to use for discussion page storage

//site notice
$conf["monobook_sitenotice"] = true; //TRUE: use/show sitenotice
$conf["monobook_sitenotice"] = 1; //1: use/show sitenotice
$conf["monobook_sitenotice_location"] = ":wiki:site_notice"; //page/article used to store the sitenotice
$conf["monobook_sitenotice_translate"] = true; //TRUE: load translated sitenotice if translation plugin is available (see <https://www.dokuwiki.org/plugin:translation>)
$conf["monobook_sitenotice_translate"] = 1; //1: load translated sitenotice if translation plugin is available (see <https://www.dokuwiki.org/plugin:translation>)

//navigation
$conf["monobook_navigation"] = true; //TRUE: use/show navigation
$conf["monobook_navigation"] = 1; //1: use/show navigation
$conf["monobook_navigation_location"] = ":wiki:navigation"; //page/article used to store the navigation
$conf["monobook_navigation_translate"] = true; //TRUE: load translated navigation if translation plugin is available (see <https://www.dokuwiki.org/plugin:translation>)
$conf["monobook_navigation_translate"] = 1; //1: load translated navigation if translation plugin is available (see <https://www.dokuwiki.org/plugin:translation>)

//custom copyright notice
$conf["monobook_copyright"] = true; //TRUE: use/show copyright notice
$conf["monobook_copyright_default"] = true; //TRUE: use default copyright notice (if copyright notice is enabled at all)
$conf["monobook_copyright"] = 1; //1: use/show copyright notice
$conf["monobook_copyright_default"] = 1; //1: use default copyright notice (if copyright notice is enabled at all)
$conf["monobook_copyright_location"] = ":wiki:copyright"; //page/article used to store a custom copyright notice
$conf["monobook_copyright_translate"] = true; //TRUE: load translated copyright notice if translation plugin is available (see <https://www.dokuwiki.org/plugin:translation>)
$conf["monobook_copyright_translate"] = 1; //1: load translated copyright notice if translation plugin is available (see <https://www.dokuwiki.org/plugin:translation>)

//search form
$conf["monobook_search"] = true; //TRUE: use/show search form
$conf["monobook_search"] = 1; //1: use/show search form

//toolbox
$conf["monobook_toolbox"] = true; //TRUE: use/show toolbox
$conf["monobook_toolbox_default"] = true; //TRUE: use default toolbox (if toolbox is enabled at all)
$conf["monobook_toolbox_default_print"] = true; //TRUE: if default toolbox is used, show printable version link?
$conf["monobook_toolbox"] = 1; //1: use/show toolbox
$conf["monobook_toolbox_default"] = 1; //1: use default toolbox (if toolbox is enabled at all)
$conf["monobook_toolbox_default_print"] = 1; //1: if default toolbox is used, show printable version link?
$conf["monobook_toolbox_location"] = ":wiki:toolbox"; //page/article used to store a custom toolbox

//qr code box
$conf["monobook_qrcodebox"] = true; //TRUE: use/show box with QR Code of current page's URL
$conf["monobook_qrcodebox"] = 1; //1: use/show box with QR Code of current page's URL

//donation link/button
$conf["monobook_donate"] = false; //TRUE: use/show donation link/button
$conf["monobook_donate"] = 0; //1: use/show donation link/button
$conf["monobook_donate_url"] = "https://donate.arsava.com/dokuwiki-template-monobook/"; //custom donation URL

//TOC
Expand All @@ -78,11 +78,7 @@
//other stuff
$conf["monobook_breadcrumbs_position"] = "bottom"; //position of breadcrumbs navigation ("top" or "bottom")
$conf["monobook_youarehere_position"] = "top"; //position of "you are here" navigation ("top" or "bottom")
if (!empty($_SERVER["HTTP_HOST"])){
$conf["monobook_cite_author"] = "Contributors of ".hsc($_SERVER["HTTP_HOST"]); //name to use for the author on the citation page (hostname included)
} else {
$conf["monobook_cite_author"] = "Anonymous Contributors"; //name to use for the author on the citation page
}
$conf["monobook_loaduserjs"] = false; //TRUE: monobook/user/user.js will be loaded
$conf["monobook_closedwiki"] = false; //TRUE: hides most tabs/functions until user is logged in
$conf["monobook_cite_author"] = "Anonymous Contributors"; //name to use for the author on the citation page
$conf["monobook_loaduserjs"] = 0; //1: monobook/user/user.js will be loaded
$conf["monobook_closedwiki"] = 0; //1: hides most tabs/functions until user is logged in

0 comments on commit 73263c1

Please sign in to comment.