Permalink
Browse files

Fix 2013-12-08 "Binky" compatibilty issue (un-saveable config)

All onoff configuration switches do not get saved when the user changes
the value. The reason was that I used true|false for "onoff" switches
although only 1|0 was allowed [1] (never noticed this).

It worked for years but the way the configuration gets parsed by DokuWiki
was changed [2] [3] after Binky RC2, so the bug affects the current
DokuWiki Binky final only.

[1] <https://www.dokuwiki.org/config#configuration_options>
[2] <splitbrain/dokuwiki@43e7001>
[3] <http://www.freelists.org/post/dokuwiki/SemiUrgent-broken-template-config-in-final-Binky,1>
  • Loading branch information...
1 parent df702ca commit e76c4479a318a70c2b7a816db11a0f2f2facc888 @andreashaerter andreashaerter committed Feb 8, 2014
Showing with 7 additions and 7 deletions.
  1. +7 −7 conf/default.php
View
@@ -33,20 +33,20 @@
}
//header navigation
-$conf["prsnl10_headernav"] = true; //TRUE: use/show header navigation
+$conf["prsnl10_headernav"] = 1; //1: use/show header navigation
$conf["prsnl10_headernav_location"] = ":wiki:navigation_header"; //page/article used to store the header navigation
//custom copyright notice
-$conf["prsnl10_copyright"] = true; //TRUE: use/show copyright notice
-$conf["prsnl10_copyright_default"] = true; //TRUE: use default copyright notice (if copyright notice is enabled at all)
+$conf["prsnl10_copyright"] = 1; //1: use/show copyright notice
+$conf["prsnl10_copyright_default"] = 1; //1: use default copyright notice (if copyright notice is enabled at all)
$conf["prsnl10_copyright_location"] = ":wiki:copyright"; //page/article used to store a custom copyright notice
//custom footer content
-$conf["prsnl10_footer"] = false; //TRUE: use/show custom footer content
+$conf["prsnl10_footer"] = 0; //1: use/show custom footer content
$conf["prsnl10_footer_location"] = ":wiki:footer"; //page/article used to store a custom footer content
//other stuff
-$conf["prsnl10_showpageinfo"] = false; //TRUE: show meta information about the current page (footer->tpl_pageinfo())
-$conf["prsnl10_hideadminlinksfromanon"] = false; //TRUE: hide admin links if client is not an authenticated user (including login link -> you have to call "example.com?do=login" manually)
-$conf["prsnl10_loaduserjs"] = false; //TRUE: prsnl10/user/user.js will be loaded
+$conf["prsnl10_showpageinfo"] = 0; //1: show meta information about the current page (footer->tpl_pageinfo())
+$conf["prsnl10_hideadminlinksfromanon"] = 0; //1: hide admin links if client is not an authenticated user (including login link -> you have to call "example.com?do=login" manually)
+$conf["prsnl10_loaduserjs"] = 0; //1: prsnl10/user/user.js will be loaded

0 comments on commit e76c447

Please sign in to comment.