Permalink
Browse files

Fix Issue #22, 2013-12-08 "Binky" compatibilty issue (un-saveable con…

…fig)

All onoff configuration switches do not get saved when the user changes
the value. The reason was that I used true|false for "onoff" switches
although only 1|0 was allowed [1] (never noticed this).

It worked for years but the way the configuration gets parsed by DokuWiki
was changed [2] [3] after Binky RC2, so the bug affects the current
DokuWiki Binky final only.

[1] <https://www.dokuwiki.org/config#configuration_options>
[2] <splitbrain/dokuwiki@43e7001>
[3] <http://www.freelists.org/post/dokuwiki/SemiUrgent-broken-template-config-in-final-Binky,1>
  • Loading branch information...
1 parent fede5d7 commit 56480ef3a57883b2a3472ac202bf303bae746a64 @andreashaerter andreashaerter committed Feb 8, 2014
Showing with 18 additions and 22 deletions.
  1. +18 −22 conf/default.php
View
@@ -33,44 +33,44 @@
}
//user pages
-$conf["vector_userpage"] = true; //TRUE: use/show user pages
+$conf["vector_userpage"] = 1; //1: use/show user pages
$conf["vector_userpage_ns"] = ":wiki:user:"; //namespace to use for user page storage
//discussion pages
-$conf["vector_discuss"] = true; //TRUE: use/show discussion pages
+$conf["vector_discuss"] = 1; //1: use/show discussion pages
$conf["vector_discuss_ns"] = ":talk:"; //namespace to use for discussion page storage
//site notice
-$conf["vector_sitenotice"] = true; //TRUE: use/show sitenotice
+$conf["vector_sitenotice"] = 1; //1: use/show sitenotice
$conf["vector_sitenotice_location"] = ":wiki:site_notice"; //page/article used to store the sitenotice
-$conf["vector_sitenotice_translate"] = true; //TRUE: load translated sitenotice if translation plugin is available (see <https://www.dokuwiki.org/plugin:translation>)
+$conf["vector_sitenotice_translate"] = 1; //1: load translated sitenotice if translation plugin is available (see <https://www.dokuwiki.org/plugin:translation>)
//navigation
-$conf["vector_navigation"] = true; //TRUE: use/show navigation
+$conf["vector_navigation"] = 1; //1: use/show navigation
$conf["vector_navigation_location"] = ":wiki:navigation"; //page/article used to store the navigation
-$conf["vector_navigation_translate"] = true; //TRUE: load translated navigation if translation plugin is available (see <https://www.dokuwiki.org/plugin:translation>)
+$conf["vector_navigation_translate"] = 1; //1: load translated navigation if translation plugin is available (see <https://www.dokuwiki.org/plugin:translation>)
//exportbox ("print/export")
-$conf["vector_exportbox"] = true; //TRUE: use/show exportbox
-$conf["vector_exportbox_default"] = true; //TRUE: use default exportbox (if exportbox is enabled at all)
+$conf["vector_exportbox"] = 1; //1: use/show exportbox
+$conf["vector_exportbox_default"] = 1; //1: use default exportbox (if exportbox is enabled at all)
$conf["vector_exportbox_location"] = ":wiki:exportbox"; //page/article used to store a custom exportbox
//toolbox
-$conf["vector_toolbox"] = true; //TRUE: use/show toolbox
-$conf["vector_toolbox_default"] = true; //TRUE: use default toolbox (if toolbox is enabled at all)
+$conf["vector_toolbox"] = 1; //1: use/show toolbox
+$conf["vector_toolbox_default"] = 1; //1: use default toolbox (if toolbox is enabled at all)
$conf["vector_toolbox_location"] = ":wiki:toolbox"; //page/article used to store a custom toolbox
//qr code box
-$conf["vector_qrcodebox"] = true; //TRUE: use/show box with QR Code of current page's URL
+$conf["vector_qrcodebox"] = 1; //1: use/show box with QR Code of current page's URL
//custom copyright notice
-$conf["vector_copyright"] = true; //TRUE: use/show copyright notice
-$conf["vector_copyright_default"] = true; //TRUE: use default copyright notice (if copyright notice is enabled at all)
+$conf["vector_copyright"] = 1; //1: use/show copyright notice
+$conf["vector_copyright_default"] = 1; //1: use default copyright notice (if copyright notice is enabled at all)
$conf["vector_copyright_location"] = ":wiki:copyright"; //page/article used to store a custom copyright notice
-$conf["vector_copyright_translate"] = true; //TRUE: load translated copyright notice if translation plugin is available (see <https://www.dokuwiki.org/plugin:translation>)
+$conf["vector_copyright_translate"] = 1; //1: load translated copyright notice if translation plugin is available (see <https://www.dokuwiki.org/plugin:translation>)
//donation link/button
-$conf["vector_donate"] = false; //TRUE: use/show donation link/button
+$conf["vector_donate"] = 0; //1: use/show donation link/button
$conf["vector_donate_url"] = "https://donate.arsava.com/dokuwiki-template-vector/"; //custom donation URL
//TOC
@@ -79,11 +79,7 @@
//other stuff
$conf["vector_breadcrumbs_position"] = "bottom"; //position of breadcrumbs navigation ("top" or "bottom")
$conf["vector_youarehere_position"] = "top"; //position of "you are here" navigation ("top" or "bottom")
-if (!empty($_SERVER["HTTP_HOST"])){
- $conf["vector_cite_author"] = "Contributors of ".hsc($_SERVER["HTTP_HOST"]); //name to use for the author on the citation page (hostname included)
-} else {
- $conf["vector_cite_author"] = "Anonymous Contributors"; //name to use for the author on the citation page
-}
-$conf["vector_loaduserjs"] = false; //TRUE: vector/user/user.js will be loaded
-$conf["vector_closedwiki"] = false; //TRUE: hides most tabs/functions until user is logged in
+$conf["vector_cite_author"] = "Anonymous Contributors"; //name to use for the author on the citation page
+$conf["vector_loaduserjs"] = 0; //1: vector/user/user.js will be loaded
+$conf["vector_closedwiki"] = 0; //1: hides most tabs/functions until user is logged in

0 comments on commit 56480ef

Please sign in to comment.