Add support for access token exchange #166

Merged
merged 3 commits into from Feb 8, 2012

Conversation

Projects
None yet
4 participants
Contributor

etiennebarrie commented Feb 6, 2012

As discussed in arsduo/koala#163.

Mocked specs implementation might not be ideal and there’s still some work to do to pass the live tests.

rud commented Feb 6, 2012

This looks like a good and friendly patch. Any chance of a release including this? The facebook offline deprecation is already being rolled out, so this would be helpful if included.

Owner

arsduo commented Feb 6, 2012

I'm merging this in now, and hope to have a release out this week, even if it means rolling out the solution to #165 in a later release. Stay tuned!

Contributor

etiennebarrie commented Feb 7, 2012

I rebased against master and fixed the live specs. I also renamed [get_]exchange_access_token and [get_]exchange_access_token_info. This last one doesn’t sound so good but meh…

I still got this one failure but it fails as well on master. I wouldn’t release Koala with this one failing though ;)

rspec ./spec/support/graph_api_shared_examples.rb:220 # Koala::Facebook::API with an access token it should behave like Koala GraphAPI with an access token can delete posts

@arsduo arsduo merged commit 1c404f3 into arsduo:master Feb 8, 2012

Owner

arsduo commented Feb 8, 2012

Hi Étienne,

Thanks again for the pull request! I've merged it into master and verified that all the tests are running properly. I think it's ready to go!

I'm seeing the same test failure you saw, but that seems to be a Facebook bug, not a problem with Koala, so I plan to release 1.4 sometime this week.

Best,

Alex

Might be good to add docs for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment