Fix failing tests #282

Merged
merged 5 commits into from Jan 15, 2013

Conversation

Projects
None yet
1 participant
Owner

arsduo commented Jan 14, 2013

FIXED: MockHTTPService no longer does string comparison; it now decodes and compares Ruby objects.
FIXED: Other failing tests are now fixed.

After building up several layers of elaborate JSON encoding and parsing hacks to deal with string comparison problems in the mocked Facebook tests, I've finally ripped all that out and now compare Ruby objects with each other. Infinitely more flexible and happy and compatible.

I've also fixed some other test failures, which seem to have arisen because stubbing Proc#call (or maybe it's #call on a block) doesn't seem to work properly with some Rubies. That's now tested another way.

Owner

arsduo commented Jan 14, 2013

The tests are failing due to internal Travis issues (see https://travis-ci.org/arsduo/koala/jobs/4148242) -- hopefully they'll fix those and Koala can finally be green again.

arsduo added a commit that referenced this pull request Jan 15, 2013

@arsduo arsduo merged commit c42db86 into master Jan 15, 2013

1 check failed

default The Travis build failed
Details

@arsduo arsduo deleted the fix-travis branch Jan 25, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment