Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on saving results with the same name than a folder #149

Closed
hsoft opened this issue Jun 22, 2013 · 3 comments

Comments

Projects
None yet
1 participant
@hsoft
Copy link
Collaborator

commented Jun 22, 2013

@@@
Application Name: dupeGuru
Version: 3.0.1

Traceback (most recent call last):
File "/home/hsoft/src/dupeguru/qt/base/result_window.py", line 338, in saveResultsTriggered
self.app.save_as(destination)
File "/home/hsoft/src/dupeguru/core/app.py", line 359, in save_as
self.results.save_to_xml(filename)
File "/home/hsoft/src/dupeguru/core/results.py", line 307, in save_to_xml
with FileOrPath(outfile, 'wb') as fp:
File "/home/hsoft/src/dupeguru/hscommon/util.py", line 302, in enter
self.fp, self.mustclose = open_if_filename(self.file_or_path, self.mode)
File "/home/hsoft/src/dupeguru/hscommon/util.py", line 290, in open_if_filename
return (open(infile, mode), True)
IOError: [Errno 21] Is a directory: '/home/hsoft/Desktop/foo'
@@@

@hsoft hsoft closed this Jun 22, 2013

@hsoft

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 22, 2013

The resolution of this bug requires significant changes to the code for something that doesn't have a lot of chances to happen. Some day, maybe, I'll fix it.

@hsoft

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 22, 2013

Or what about simply using name conflict resolution for this case? Very rare case, bit of a hacky fix, but at least it doesn't crash.

@hsoft

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 22, 2013

(from [3dfd27cc3856]) [#149 state:fixed] Fixed crash on result saving.
https://bitbucket.org/hsoft/dupeguru/changeset/3dfd27cc3856/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.