Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap winshell error when sending to trash #62

Closed
hsoft opened this issue Jun 22, 2013 · 3 comments

Comments

Projects
None yet
1 participant
@hsoft
Copy link
Collaborator

commented Jun 22, 2013

Winshell errors are not wrapped and result to error dialogs.

@@@
Traceback (most recent call last):
File "C:\src\dupeguru\me\build\pyi.win32\dgme\outPYZ1.pyz/hsutil.job", line 199, in _async_run
File "C:\src\dupeguru\me\build\pyi.win32\dgme\outPYZ1.pyz/dupeguru.app", line 68, in _do_delete
File "C:\src\dupeguru\me\build\pyi.win32\dgme\outPYZ1.pyz/dupeguru.results", line 223, in perform_on_marked
File "C:\src\dupeguru\me\build\pyi.win32\dgme\outPYZ1.pyz/dupeguru.app", line 65, in op
File "C:\src\dupeguru\me\build\pyi.win32\dgme\outPYZ1.pyz/dupeguru.app", line 74, in _do_delete_dupe
File "C:\src\dupeguru\me\build\pyi.win32\dgme\outPYZ1.pyz/base.app", line 157, in _recycle_dupe
File "C:\src\dupeguru\me\build\pyi.win32\dgme\outPYZ1.pyz/base.win", line 14, in recycle_file
File "C:\src\dupeguru\me\build\pyi.win32\dgme\outPYZ1.pyz/winshell", line 252, in delete_file
File "C:\src\dupeguru\me\build\pyi.win32\dgme\outPYZ1.pyz/winshell", line 139, in _file_operation
x_winshell: 1223
@@@

@hsoft hsoft closed this Jun 22, 2013

@hsoft

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 22, 2013

The wrapper should try to get a readable version of the message and send it to log. There should be indication in the post-operation dialog that tells the user to look in the debug log.

@hsoft

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 22, 2013

[milestone:id#51279 bulk edit command]

@hsoft

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 22, 2013

(from [164]) [#62 state:fixed] Wrapped winshell exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.