New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output of getTimeStampFromCurrentDateFormat #77

Open
arshadkazmi42 opened this Issue Oct 5, 2018 · 8 comments

Comments

Projects
None yet
2 participants
@arshadkazmi42
Owner

arshadkazmi42 commented Oct 5, 2018

Add output of the usage in readme file here

https://github.com/arshadkazmi42/custom-date-formatting#gettimestampfromcurrentdateformat

Add this output

Output: 1503858600000

@Apoorva-13

This comment has been minimized.

Show comment
Hide comment
@Apoorva-13

Apoorva-13 Oct 5, 2018

Contributor

I would like to work on this.

Contributor

Apoorva-13 commented Oct 5, 2018

I would like to work on this.

@arshadkazmi42

This comment has been minimized.

Show comment
Hide comment
@arshadkazmi42

arshadkazmi42 Oct 5, 2018

Owner

Cool. Go ahead

Owner

arshadkazmi42 commented Oct 5, 2018

Cool. Go ahead

@Apoorva-13

This comment has been minimized.

Show comment
Hide comment
@Apoorva-13

Apoorva-13 Oct 5, 2018

Contributor

where exactly i have to place this output? and what should be the format?

Contributor

Apoorva-13 commented Oct 5, 2018

where exactly i have to place this output? and what should be the format?

@arshadkazmi42

This comment has been minimized.

Show comment
Hide comment
@arshadkazmi42

arshadkazmi42 Oct 5, 2018

Owner

@Apoorva-13 add it here

screen shot 2018-10-06 at 1 08 53 am

Below the last line

Owner

arshadkazmi42 commented Oct 5, 2018

@Apoorva-13 add it here

screen shot 2018-10-06 at 1 08 53 am

Below the last line

@Apoorva-13

This comment has been minimized.

Show comment
Hide comment
@Apoorva-13

Apoorva-13 Oct 5, 2018

Contributor

ok sure thanks:)

Contributor

Apoorva-13 commented Oct 5, 2018

ok sure thanks:)

@arshadkazmi42

This comment has been minimized.

Show comment
Hide comment
@arshadkazmi42

arshadkazmi42 Oct 14, 2018

Owner

@Apoorva-13 any updates on this? There are few requested changes pending in your PR

Owner

arshadkazmi42 commented Oct 14, 2018

@Apoorva-13 any updates on this? There are few requested changes pending in your PR

@Apoorva-13

This comment has been minimized.

Show comment
Hide comment
@Apoorva-13

Apoorva-13 Oct 14, 2018

Contributor

I have made separate pr requests now, is there any other change as well?

Contributor

Apoorva-13 commented Oct 14, 2018

I have made separate pr requests now, is there any other change as well?

@arshadkazmi42

This comment has been minimized.

Show comment
Hide comment
@arshadkazmi42

arshadkazmi42 Oct 14, 2018

Owner

You have created a new PR for gitignore, but you have not updated your existing PR.
https://github.com/arshadkazmi42/custom-date-formatting/pull/85/files

Should I close this PR? As gitignore changes are there in this PR also.

Owner

arshadkazmi42 commented Oct 14, 2018

You have created a new PR for gitignore, but you have not updated your existing PR.
https://github.com/arshadkazmi42/custom-date-formatting/pull/85/files

Should I close this PR? As gitignore changes are there in this PR also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment