Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django-inline-ordering does not work #44

Closed
rfleschenberg opened this issue Nov 2, 2016 · 1 comment
Closed

django-inline-ordering does not work #44

rfleschenberg opened this issue Nov 2, 2016 · 1 comment
Assignees

Comments

@rfleschenberg
Copy link
Contributor

rfleschenberg commented Nov 2, 2016

It seems that cmsplugin-contact-plus depends on django-inline-ordering. The user should add django-inline-ordering to INSTALLED_APPS, but this is not documented. Easy fix, add this to the README.

However, with inline-ordering in INSTALLED_APPS, I am running into another problem:

Uncaught TypeError: InlineOrdering.jQuery(...).sortable is not a function

The last commit in https://github.com/centralniak/django-inline-ordering is from 2013. Maybe it's time to replace that dependency?

@jvamvas
Copy link
Contributor

jvamvas commented Feb 27, 2017

Thank you for pointing this out, @rfleschenberg. With v1.3.5, we have replaced django-inline-ordering with https://github.com/iambrandontaylor/django-admin-sortable.

Please note the upgrading instruction on https://github.com/arteria/cmsplugin-contact-plus/releases/tag/v1.3.5

@jvamvas jvamvas closed this as completed Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants