New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds the capability to read from google.maps.Data objects (+ jasmine tests) #51

Merged
merged 4 commits into from Jul 30, 2014

Conversation

Projects
None yet
2 participants
@amenadiel
Contributor

amenadiel commented Jul 28, 2014

  • This PR adds the capability to ingest geometry objects of the google.maps.Data family.
    • Data.Point
    • Data.MultiPoint
    • Data.LineString
    • Data.MultiLineString
    • Data.LinearRing
    • Data.Polygon
    • Data.MultiPolygon
    • Data.GeometryCollection (* partially)

they can be read with the usual wkt.fromObject(object); syntax.

  • There is also a method to ingest Data.Feature objects which is a proxy to read the feature geometry, so at this point wkt.fromObject(feature); is just a shortcut for wkt.fromObject(feature.getGeometry);
  • Bonus track: I also added the capability to ingest google.maps.LatLngBounds objects, because the map, circles, groundoverlays and other objects have a bounds property, and it's cumbersome to instantiate a temporary rectangle just to get the WKT translation of such bounds.

@todo list

  • Add the capability to ingest google.maps.Data.Feature objects parsing their properties and make their json representation a proper GeoJSON Feature.
  • Add the capability to ingest google.maps.Data objects and make their json representation a proper GeoJSON FeatureCollection.
  • Add methods to instantiate google.maps.Data objects using .toDataObject() on a wkt object.
  • Complete the GeometryCollection functionality. At this point it cannot be exported, since WKT Geometrycollection is not supported.

arthur-e added a commit that referenced this pull request Jul 30, 2014

Merge pull request #51 from amenadiel/master
Adds the capability to read from google.maps.Data objects (+ jasmine tests)

@arthur-e arthur-e merged commit eca795a into arthur-e:master Jul 30, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@amenadiel

This comment has been minimized.

Contributor

amenadiel commented Jul 30, 2014

Woohoo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment