arthuredelstein / torbutton Public

Fixes bug in the main 20347 patch, reported at
https://trac.torproject.org/projects/tor/ticket/20347#comment:13

This patch moves the security slider code from torbutton.js
to its own file (security-prefs.js) and refactors it.

Retrieve SOCKS port configuration from Tor Launcher if available.
Support the TOR_SOCKS_IPC_PATH environment variable.

Consistently use IPC to refer to Unix domain sockets.

Enhance torbutton_local_tor_check() to correctly handle spaces and
escaped characters within the 'GETINFO net/listeners/socks' response.

Within startup-observer.js, use Services.jsm, Cc and similar
constants, and remove unused code.

Also, remove the 'extensions.torbutton.resist_fingerprinting' pref
and just use the 'privacy.resistFingerprinting' pref instead. We will
use this to implement a checkbox in the about:preferences#privacy page.

Also, we remove the 'extensions.torbutton.restrict_thirdparty'
and use the 'privacy.thirdparty.isolate' pref. At the same time we
will need to add a checkbox to the about:preferences#privacy page
that toggles 'privacy.thirdparty.isolate'.

Note that 'privacy.thirdparty.isolate' will be renamed to
'privacy.firstparty.isolate' in Firefox 52.

This patch also removes the 'extensions.torbutton.no_tor_plugin'
pref and simply uses the 'plugin.disable' pref instead.

Thanks to our patch for Bug 10280 in tor-browser.git,
buttons on the plugins section of about:addons
already let you "Enable plugins" and "Disable plugins"
(i.e., toggle the 'plugin.disable' pref).

Also it's probably better to remove this footgun in the UI.

…tings

An equivalent checkbox, "Always use private browsing mode"
is already available in about:preferences#privacy. Better to leave
it more hidden from the user in any case, as it is inadvisable
to disable private browsing mode.

We remove the 'extensions.torbutton.block_disk' pref and use the
'browser.privatebrowsing.autostart' pref instead, because they
are equivalent.

We'll also use add a patch to disable remote jars in tor-browser.git

If the dialog is too small to show all descriptions, then the
descriptions text area will show a scrollbar.