Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Disabled behavior added #17

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

fungio commented Mar 23, 2013

No description provided.

Owner

arthurgouveia commented Apr 1, 2013

Hey, man! Thanks for that. Sorry for the long time to reply.

I'll be checking the pull request and merging stuff next week, ok?

fungio commented Apr 1, 2013

No problem.

@arthurgouveia arthurgouveia commented on the diff Apr 16, 2013

prettyCheckable.js
- input.attr('checked', 'checked').change();
-
- }
-
- fakeCheckable.toggleClass('checked');
+
+ if (input.attr('disabled') === undefined) {
+ if (input.attr('checked') !== undefined) {
+ input.removeAttr('checked').change();
+ } else {
+ input.attr('checked', 'checked').change();
+ }
+
+ fakeCheckable.toggleClass('checked');
+ } else {
+ console.log('disabled');
Owner

arthurgouveia commented Apr 16, 2013

Hey, man! Sorry again for taking such a long time to do this.

I reversed the logic you added on the code and also added the possibility to enable/disabled checkables using methods. Because of the amount of code, I decided to just push it all instead of pulling your code and changing it.

Thanks for that, anyway. People have been asking me for this for quite some time. I hope it works fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment