Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make disqus_dev tag set disqus_url to full URL for page. #29

Merged
merged 8 commits into from Jul 17, 2014

Conversation

Projects
None yet
2 participants
Contributor

qris commented Jan 9, 2014

Otherwise all comments made on the dev site are attached to the root of the
site, not to their respective pages.

qris added some commits Jan 9, 2014

Replace doctests with unittest
For now we test the same as the old doctests
Make disqus_dev tag set disqus_url to full URL for page.
Otherwise all comments made on the dev site are attached to the root of the
site, not to their respective pages.
Add disqus_sso tag
So users who are logged into the Django site can post comments to Disqus
without having to log in to disqus separately
Simplify templatetag registration, allow setting disqus_category_id.
Automatically merge multiple arguments passed to disqus_url templatetag, as
this allows you to write:

    {% set_disqus_identifier request.get_host "/" unique_object_id %}
    {% set_disqus_url "http://" request.get_host request.path %}

in your templates and have them concatenated to valid identifiers and URLs
automatically, without writing any code in your view.
Merge branch 'master' of https://github.com/arthurk/django-disqus
Remove the protocol from the URL, to support https as well as http, while
keeping the fix that attaches comments to the correct page instead of the
site root URL.

Conflicts:
	disqus/templatetags/disqus_tags.py

derekjamescurtis added a commit that referenced this pull request Jul 17, 2014

Merge pull request #29 from aptivate/master
Make disqus_dev tag set disqus_url to full URL for page.

@derekjamescurtis derekjamescurtis merged commit 173f01f into arthurk:master Jul 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment