Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken connections are not repaired #37

Closed
freeatnet opened this issue Aug 24, 2013 · 1 comment · Fixed by #38
Closed

Broken connections are not repaired #37

freeatnet opened this issue Aug 24, 2013 · 1 comment · Fixed by #38

Comments

@freeatnet
Copy link
Contributor

Steps to reproduce:

  1. Launch APN sender in a loop where the connection pool is persisted despite exceptions (i.e., Sidekiq).
  2. Start sending notifications.
  3. Simulate network problems.

Expected behaviour: Broken connections are repaired or discarded, failed messages are possibly retried.
Observed behaviour: Broken connections are supplied for the next messages.

@freeatnet
Copy link
Contributor Author

The issue can be reproduced locally:

  1. Check out freeatnet@489eb97
  2. Run sample_keygen.rb in contrib. This should produce priv.pem and apn_production.pem, used by APN and the sample server.
  3. Start sample_server.rb.
  4. Simultaneously, start sample_client.rb. NB: this may require running it with bundle exec.
  5. Ensure that messages are being sent successfully.
  6. Press Enter a few times in the console running sample_server.rb to close some connections.
  7. Note the error messages in sample_client.rb output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant