Permalink
Browse files

Move set_inverse_instance to association.build_record

[fixes #10371]
  • Loading branch information...
1 parent 54c05ac commit 679860400f1c6c542b33e8c80221cc5aca7b5629 @arthurnn committed Sep 30, 2013
@@ -1,4 +1,10 @@
## unreleased ##
+* Move .set_inverse_instance call to association.build_record method. Everytime a new record is build
+ using the association, we need to try to set the inverse_of relation.
+
+ Fixes #10371.
+
+ *arthurnn*
* When calling the method .find_or_initialize_by_* from a collection_proxy
it should set the inverse_of relation even when the entry was found on the db.
@@ -240,6 +240,7 @@ def build_record(attributes, options)
skip_assign = [reflection.foreign_key, reflection.type].compact
attributes = create_scope.except(*(record.changed - skip_assign))
record.assign_attributes(attributes, :without_protection => true)
+ set_inverse_instance(record)
end
end
end
@@ -350,7 +350,6 @@ def add_to_target(record)
end
callback(:after_add, record)
- set_inverse_instance(record)
record
end
@@ -125,8 +125,10 @@ def test_parent_instance_should_be_shared_with_newly_built_child
end
def test_parent_instance_should_be_shared_with_newly_created_child
- m = Man.find(:first)
+ m = Man.create
f = m.create_face(:description => 'haunted')
+
+ assert_equal m.object_id, f.man.object_id
assert_not_nil f.man
assert_equal m.name, f.man.name, "Name of man should be the same before changes to parent instance"
m.name = 'Bongo'

0 comments on commit 6798604

Please sign in to comment.