Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close will-rowe/artic-tools#12 - where minion does not index the merged.vcf prior to checking for overlaps in
--strict
mode. I tracked this down to actually being a dependency change, as it worked in my old artic env (<1.2.0). The fix was just to add an extra VCF indexing command to minion.py if the pipeline was being run with--strict
This PR also:
--strict
, so the extra files aren't produced using the existing pipeline.This branch will stay open after this PR is merged and I'll continue working toward the V1.3.0 release, where we want to increase the amount of info in the new report, bring in the new medaka version, and try out some additional stringency settings.