Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch 1.2.0 > 1.2.1 #68

Merged
merged 5 commits into from
Jan 14, 2021
Merged

patch 1.2.0 > 1.2.1 #68

merged 5 commits into from
Jan 14, 2021

Conversation

will-rowe
Copy link

This will close will-rowe/artic-tools#12 - where minion does not index the merged.vcf prior to checking for overlaps in --strict mode. I tracked this down to actually being a dependency change, as it worked in my old artic env (<1.2.0). The fix was just to add an extra VCF indexing command to minion.py if the pipeline was being run with --strict

This PR also:

  • removes the reliance on a MultiQC artic module, instead we generate some stats from the align_trim output and the vcf_check output, storing these as a JSON file which MultiQC can munch on. I've included this as a feature enabled by --strict, so the extra files aren't produced using the existing pipeline.
  • updates the doc with some missing minion sub commands
  • bumps the version number with the patch

This branch will stay open after this PR is merged and I'll continue working toward the V1.3.0 release, where we want to increase the amount of info in the new report, bring in the new medaka version, and try out some additional stringency settings.

@nickloman nickloman merged commit 23a8460 into master Jan 14, 2021
@kevinlibuit
Copy link

Curious to know if this will be made available as a versioned release?

kirstyn added a commit to kirstyn/fieldbioinformatics that referenced this pull request May 15, 2023
…dev"

This reverts commit 23a8460, reversing
changes made to d5a0cb8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--strict fails
3 participants