Impl. Integer#size in Rust #212
Conversation
| pub unsafe extern "C" fn size(mrb: *mut sys::mrb_state, slf: sys::mrb_value) -> sys::mrb_value { | ||
| let interp = unwrap_interpreter!(mrb); | ||
| let nil = Value::convert(&interp, None::<Value>); | ||
| if let Ok(_value) = Int::try_convert(&interp, Value::new(&interp, slf)) { |
There was a problem hiding this comment.
I prefer calling is_ok to check if a Result is Ok rather than doing an if let and ignoring the binding.
| if let Ok(size) = Int::try_from(mem::size_of::<Int>()) { | ||
| Value::convert(&interp, size).inner() | ||
| } else { | ||
| nil.inner() |
There was a problem hiding this comment.
this is a fatal error. usize should always be at least as large as Int. Typically, we deal with fatal errors by raising a RuntimeError like
artichoke/artichoke-backend/src/extn/core/matchdata/mod.rs
Lines 146 to 148 in 5d55ce6
| nil.inner() | ||
| } | ||
| } else { | ||
| nil.inner() |
There was a problem hiding this comment.
this is a fatal error. slf should always be convertible to an Int (or Bignum) becasue slf is a Ruby Integer. Typically, we deal with fatal errors by raising a RuntimeError like
artichoke/artichoke-backend/src/extn/core/matchdata/mod.rs
Lines 146 to 148 in 5d55ce6
lopopolo
added
A-core
This PR implements
Integer#sizein Rust.Fixes #179
Ran the tests (integer/size_spec.rb), only passed for the fixnum's not the bignum's.