Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wasi platform support to scolapasta-path #2170

Merged
merged 1 commit into from Sep 4, 2022
Merged

Add wasi platform support to scolapasta-path #2170

merged 1 commit into from Sep 4, 2022

Conversation

jcaesar
Copy link
Contributor

@jcaesar jcaesar commented Sep 4, 2022 •
edited by lopopolo

Takes care of #2111 without code duplication.

Fixes #2111.

@lopopolo lopopolo added the A-filesystem Area: Filesystem access and implementations. label Sep 4, 2022
lopopolo
lopopolo approved these changes Sep 4, 2022
View reviewed changes
Copy link
Member

@lopopolo lopopolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! I like that you've found a way to combine the unix module with this new wasi code.

Thank you! 💎

@lopopolo lopopolo merged commit e698ee4 into artichoke:trunk Sep 4, 2022
@lopopolo lopopolo added A-build-target Area: Support for builds of specific targets. O-wasm-wasi Target: Support for building the `wasm32-wasi` target. labels Sep 4, 2022
@jcaesar jcaesar deleted the wasi-path branch September 4, 2022 23:21
lopopolo added a commit that referenced this pull request Sep 10, 2022
@lopopolo
Add wasm category to scolapasta-path
34f3e76 
Followup to #2170.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lopopolo lopopolo lopopolo approved these changes

Assignees
No one assigned
Labels
A-build-target Area: Support for builds of specific targets. A-filesystem Area: Filesystem access and implementations. O-wasm-wasi Target: Support for building the `wasm32-wasi` target.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add wasi platform support to scolapasta-path
2 participants
@jcaesar @lopopolo