This repository was archived by the owner on Nov 3, 2025. It is now read-only.
Fix parsing bugs and add tests to artichoke-readline#2597
Merged
Conversation
Fix some bugs with the help of ChatGPT: - Quoted values are not allowed in `set` directives per GNU Readline documentation. - Handle trailing garbage after a valid `set` directive. - `emacs` and `vi` directive values are case insensitive. Add many more tests: - Integration tests with full configs. - Lots of tests with invalid UTF-8 byte sequences. - Lots of tests with multi-byte UTF-8 characters. Bump artichoke-readline to v1.0.1.
Last one wins.
lopopolo
added
A-parser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pair programming with ChatGPT: https://chat.openai.com/c/f1a56877-ed9a-4fa9-92a8-9b0fe4763e82
Changes:
viandemacsvalues insetdirective.setdirective.viandemacsdirective values as case-insensitive.setdirectives, the last one wins.Many more tests are added, generated with help:
Added some additional comments to the parser to clarify parse steps.