-
Notifications
You must be signed in to change notification settings - Fork 0
Dockerfile
and docker build improvements
#167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The `128142` UID and GID previously used corresponded to the decimal encoding of the gem emoji ('💎') Unicode character. In conversations with ChatGPT, this ID is outside the typical range on most Linux distributions: > In most Linux distributions, the valid range for UIDs and GIDs is from > 0 to 65535 (inclusive). However, there are reserved ranges and conventions > that dictate the allocation of UIDs and GIDs. For example, UIDs below 1000 > are often reserved for system users and groups, while UIDs above 1000 are > typically used for regular users. > > In the case of UID/GID 128142, it falls outside the typical valid range of > UIDs and GIDs on Linux systems. Therefore, it may not be considered a valid > UID/GID. Use `1888` for UID and GID of the `artichoke` user, which adheres to these guidelines.
Pass `THIRDPARTY` file as a build arg.
f95b466
to
720707d
Compare
Here's a code review from ChatGPT:
|
I did some pair programming with ChatGPT here: https://chat.openai.com/c/b88a7262-4fb5-4062-8c32-eed75b809f43.
Improvements
Dockerfile
s.empty.txt
hack for the optionalTHIRDPARTY
file, preferring to use a build ARG..dockerignore
file.