Skip to content

URL parsing fails on URLs with port numbers #6

Closed
bgulanowski opened this Issue Jul 7, 2011 · 3 comments

2 participants

@bgulanowski

I'm not sure precisely what's happening in -filenameForURLString:, but the handling of the port number substring is broken. The existing regex is invalid (there are two repetition specifiers, when only one is permitted). But when I fixed it (removing the "?"), it caused the hostname and the first element of the path to squeeze together.

Simply ripping out the port is probably a bad idea. It might be better to replace the colon with an underscore. I'm going to try that myself.

@artifacts
Owner

Can you post an example of a broken URL?

@bgulanowski

http://localhost:3000/blah/

becomes

localhostblah

I modified it to output "localhost_3000/blah"

@artifacts
Owner

won't happen anymore since filenames are hashes now

@artifacts artifacts closed this Sep 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.