Skip to content

Fix #1027: Don't fail capture on false boolean values - #1044

Merged
hassy merged 1 commit into
artilleryio:masterfrom
RohanNagar:master
May 24, 2021
Merged

hassy merged 1 commit into
artilleryio:masterfrom
RohanNagar:master

Conversation

@RohanNagar

@RohanNagar RohanNagar commented May 22, 2021 •

Copy link
Copy Markdown
Contributor

Closes #1027

@mkadirtan

Copy link
Copy Markdown
Contributor

Closes #1027 and closes #1040.

No, this PR doesn't close #1040 . You can check #1041 , the problem with #1040 is when using captureOrMatch

@RohanNagar

Copy link
Copy Markdown
Contributor Author

Got it, updated the description.

@hassy

hassy commented May 23, 2021

Copy link
Copy Markdown
Member

Nice! Could you update the commit message to follow the existing convention? Something like fix: don't fail capture on false boolean values. That's the step that's failing on CirlceCI right now.

(You can edit the commit message with git commit --amend in your branch, then git push --force to your branch to overwrite)

@RohanNagar

Copy link
Copy Markdown
Contributor Author

@hassy fixed! The build passes now.

@hassy

hassy commented May 24, 2021

Copy link
Copy Markdown
Member

Nice! 🎉

@hassy
hassy merged commit 855462a into artilleryio:master May 24, 2021
@RohanNagar

Copy link
Copy Markdown
Contributor Author

@hassy I noticed the latest release (1.7.3) doesn't include this fix - would you be able to include it in the next release? Thank you!

@RohanNagar

Copy link
Copy Markdown
Contributor Author

@hassy any update on this?

@hassy

hassy commented Jul 1, 2021

Copy link
Copy Markdown
Member

@RohanNagar the commit has been backported to the v1.7 branch now and will be rolled out in the next v1.7 release (most likely tomorrow)

eslof2 pushed a commit to eslof2/artillery-examples-fork that referenced this pull request Aug 31, 2025
Fix artilleryio#1027: Don't fail capture on false boolean values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version 1.7.0 Breaks Boolean Capture

3 participants