Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend RpmTest #227

Closed
6 tasks done
olenagerasimova opened this issue Jun 3, 2020 · 5 comments
Closed
6 tasks done

Extend RpmTest #227

olenagerasimova opened this issue Jun 3, 2020 · 5 comments
Assignees

Comments

@olenagerasimova
Copy link
Member

olenagerasimova commented Jun 3, 2020

Test for Rpm have to be extended:

  • in doesntBrakeMetadataWhenInvalidPackageSent we have make sure that not only repomd.xml is not changed, but other 3 metadata files: primary, other and filelist. The best way to check it I see is to stash xmls after the first update and compare them against the files after second update with broken package.
  • we have to make sure that tempdir is cleaned up after the update
  • it's necessary to verify that old (previous) meta xmls are removed (verified by StorageHasMetadata matcher)
  • metadata files are stored in the correct location: repodata folder relatively to the prefix (verified by StorageHasMetadata matcher)
  • update of the same (with no new/deleted rpms) repository for the second time is successful (covered in updatesDifferentReposSimultaneouslyTwice)
  • make sure cleanup is called on different errors (throwsExceptionWhenFullUpdatesDoneSimultaneously and skipsInvalidPackageOnUpdate)

All the check have to made for both batchUpdate and updateBatchIncrementally.

@0crat
Copy link

0crat commented Jun 3, 2020

@g4s8/z please, pay attention to this issue

@olenagerasimova olenagerasimova self-assigned this Oct 29, 2020
olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Oct 29, 2020
olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Oct 29, 2020
olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Oct 29, 2020
olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Oct 29, 2020
olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Oct 29, 2020
olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Oct 29, 2020
olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Oct 29, 2020
olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Oct 29, 2020
olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Oct 30, 2020
olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Oct 30, 2020
olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Oct 30, 2020
olenagerasimova added a commit that referenced this issue Oct 30, 2020
olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Oct 30, 2020
olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Oct 30, 2020
olenagerasimova referenced this issue in olenagerasimova/rpm-adapter Oct 30, 2020
olenagerasimova added a commit that referenced this issue Oct 30, 2020
@olenagerasimova
Copy link
Member Author

all done in RpmTest

@olenagerasimova
Copy link
Member Author

@rultor release, tag=1.3

@rultor
Copy link

rultor commented Nov 5, 2020

@rultor release, tag=1.3

@olenagerasimova OK, I will release it now. Please check the progress here

@rultor
Copy link

rultor commented Nov 5, 2020

@rultor release, tag=1.3

@olenagerasimova Done! FYI, the full log is here (took me 14min)

@0crat 0crat removed the 0crat/scope label Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants