Fix status and date on waiting list #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,4 +12,22 @@ export default DS.Model.extend({ | |||
| credit: DS.attr('string'), | |||
| want: DS.attr('string'), | |||
| notes: DS.attr('string'), | |||
|
|
|||
| statusText: function() { | |||
There was a problem hiding this comment.
nitpick: Ember.computed('status', function() { is currently preferred to prototype extension syntax
There was a problem hiding this comment.
On Aug 22, 2015, at 18:43, Ricardo Mendes notifications@github.com wrote:
In app/models/customer.js:
@@ -12,4 +12,22 @@ export default DS.Model.extend({
credit: DS.attr('string'),
want: DS.attr('string'),
notes: DS.attr('string'),
+
- statusText: function() {
nitpick: Ember.computed('status', function() { is currently preferred to prototype extension syntax—
Reply to this email directly or view it on GitHub.
|
r+, (though i sort think these should be helpers, fine for now) |
|
squash |
Also, format them correctly. Relies on artisan-tattoo/assistant-api#75 Fixes #50
|
Squashed! |
ashleygwilliams
added a commit
that referenced
this pull request
Aug 23, 2015
Fix status and date on waiting list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Make both of these fields work.
There's a small amount of DRY violation going on, and it's possible that instead of computed properties, these should be helpers. I slightly prefer computed properties but it's no biggie either way.