Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #16 #17

Merged
merged 1 commit into from Jul 5, 2019

Conversation

Projects
None yet
2 participants
@dportalesr
Copy link
Contributor

commented Jul 5, 2019

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build-related change
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch (There's no develop branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • [] All tests are passing (Tests are not passing in master and no new tests are failing)
  • [] New/updated tests are included

@faustbrian faustbrian merged commit bf522ce into artisanry:master Jul 5, 2019

1 check failed

continuous-integration/styleci/pr Issues have been identified with 1 file
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.