Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible to Illuminate\Support\Collection #3

Closed
kkrieger85 opened this Issue Mar 15, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@kkrieger85
Copy link

kkrieger85 commented Mar 15, 2019

Declaration of Konekt\Menu\ItemCollection::add(Konekt\Menu\Item $item) should be compatible with Illuminate\Support\Collection::add($item)

This error occurs on installation of https://github.com/vanilophp/framework

Please see vanilophp/framework#39

Maybe it's because of differente laravel/framework version.

@fulopattila122 fulopattila122 self-assigned this Mar 16, 2019

@fulopattila122 fulopattila122 added the bug label Mar 16, 2019

@fulopattila122

This comment has been minimized.

Copy link
Member

fulopattila122 commented Mar 16, 2019

Originally caused by laravel/framework#27082. Looks like an undocumented BC in Laravel 5.8. At least in our case it is.

@fulopattila122

This comment has been minimized.

Copy link
Member

fulopattila122 commented Mar 16, 2019

Fix for this has been released in v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.