New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made changes to Artsy contact and updated date #119

Merged
merged 6 commits into from Jul 25, 2017

Conversation

Projects
None yet
3 participants
@ystarr
Contributor

ystarr commented Feb 20, 2017

Reviewed and updated last two sections of API Terms

@dblock

This comment has been minimized.

Show comment
Hide comment
@dblock

dblock Feb 20, 2017

Member

@orta I'm helping Yayoi with this, for now don't merge.

Member

dblock commented Feb 20, 2017

@orta I'm helping Yayoi with this, for now don't merge.

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Feb 20, 2017

Member

😍

Member

orta commented Feb 20, 2017

😍

@ystarr

This comment has been minimized.

Show comment
Hide comment
@ystarr

ystarr Feb 21, 2017

Contributor

Still reviewing these terms -- trying to get them shorter and slightly more friendly. Major changes will include: (i) allowing production; (ii) stressing that this is for non-commercial use only; and (iii) making clear that the Artwork Images and resulting info being provided is public domain.

Hope to finish my review before week's end and will ping you again then!

Contributor

ystarr commented Feb 21, 2017

Still reviewing these terms -- trying to get them shorter and slightly more friendly. Major changes will include: (i) allowing production; (ii) stressing that this is for non-commercial use only; and (iii) making clear that the Artwork Images and resulting info being provided is public domain.

Hope to finish my review before week's end and will ping you again then!

@ystarr

This comment has been minimized.

Show comment
Hide comment
@ystarr

ystarr Mar 1, 2017

Contributor

@orta @dblock -- as I continue to think this through, practical question for you experts both:

  1. Currently, do we have any restrictions on what API is released? (I ask this b/c I understand from a biz perspective, provenance and valuation data, for e.g., is our special sauce, and if possible, I'd like to not have our project be the open door to release this info.)

  2. To cover the above concern, I think that releasing Public Domain images for non-commercial use will help a lot. Just to understand the bucket of stuff that we intend to release based upon this concept, if we decide to just release public domain images + metadata:

a. How many works is this (even approximately)?

b. How many artists is this (even approximately)?

c. Are these hi-res or low-res images?

d. Does it include values of genome data?

e. Will the metadata include transaction/ownership (for e.g., gallery transactions or historical provenance) -- if so, how many records?

Look forward to your thoughts and, as always, thanks so much for dealing with me the newbie!
Y

Contributor

ystarr commented Mar 1, 2017

@orta @dblock -- as I continue to think this through, practical question for you experts both:

  1. Currently, do we have any restrictions on what API is released? (I ask this b/c I understand from a biz perspective, provenance and valuation data, for e.g., is our special sauce, and if possible, I'd like to not have our project be the open door to release this info.)

  2. To cover the above concern, I think that releasing Public Domain images for non-commercial use will help a lot. Just to understand the bucket of stuff that we intend to release based upon this concept, if we decide to just release public domain images + metadata:

a. How many works is this (even approximately)?

b. How many artists is this (even approximately)?

c. Are these hi-res or low-res images?

d. Does it include values of genome data?

e. Will the metadata include transaction/ownership (for e.g., gallery transactions or historical provenance) -- if so, how many records?

Look forward to your thoughts and, as always, thanks so much for dealing with me the newbie!
Y

@dblock

This comment has been minimized.

Show comment
Hide comment
@dblock

dblock Mar 8, 2017

Member

@ystarr

Instead of limiting what we release in terms, we make sure that the API behaves in the same way as the terms describe. So if we release metadata + images of public domain works only that would be just the change in terms and no API code changes since the API does exactly that currently.

a. How many works is this?

26024 works

b. How many artists is this (even approximately)?

The API currently returns all artists with their metadata, doesn't restrict to artists that have public domain works, which is 70776. If we decide to only release artists with public domain works that would be 4321 artists.

c. Are these hi-res or low-res images?

It varies wildly depending on the provider.

d. Does it include values of genome data?

We have never released genome values, but we have released publicly visible genes (as tags). We don't plan to release genome data currently.

e. Will the metadata include transaction/ownership (for e.g., gallery transactions or historical provenance) -- if so, how many records?

Definitely not transactions, but historical provenance that's available on artsy.net is part of the current data, see https://developers.artsy.net/docs/artworks.

Member

dblock commented Mar 8, 2017

@ystarr

Instead of limiting what we release in terms, we make sure that the API behaves in the same way as the terms describe. So if we release metadata + images of public domain works only that would be just the change in terms and no API code changes since the API does exactly that currently.

a. How many works is this?

26024 works

b. How many artists is this (even approximately)?

The API currently returns all artists with their metadata, doesn't restrict to artists that have public domain works, which is 70776. If we decide to only release artists with public domain works that would be 4321 artists.

c. Are these hi-res or low-res images?

It varies wildly depending on the provider.

d. Does it include values of genome data?

We have never released genome values, but we have released publicly visible genes (as tags). We don't plan to release genome data currently.

e. Will the metadata include transaction/ownership (for e.g., gallery transactions or historical provenance) -- if so, how many records?

Definitely not transactions, but historical provenance that's available on artsy.net is part of the current data, see https://developers.artsy.net/docs/artworks.

@ystarr

This comment has been minimized.

Show comment
Hide comment
@ystarr

ystarr Mar 8, 2017

Contributor

@dblock

Thank you so much for the update. Makes sense.

Final confirmation and question -- artists with public domain works is 4321 artists. The resulting image numbers would be 26,024 works or smtg less?

Thanks
Y

Contributor

ystarr commented Mar 8, 2017

@dblock

Thank you so much for the update. Makes sense.

Final confirmation and question -- artists with public domain works is 4321 artists. The resulting image numbers would be 26,024 works or smtg less?

Thanks
Y

@dblock

This comment has been minimized.

Show comment
Hide comment
@dblock

dblock Mar 8, 2017

Member

Correct @ystarr, we have 26,024 public domain works by 4321 artists with that many images. Note that number changes all the time :)

Member

dblock commented Mar 8, 2017

Correct @ystarr, we have 26,024 public domain works by 4321 artists with that many images. Note that number changes all the time :)

@ystarr

This comment has been minimized.

Show comment
Hide comment
@ystarr

ystarr Mar 8, 2017

Contributor

Great and thanks @dblock . More soon.

Contributor

ystarr commented Mar 8, 2017

Great and thanks @dblock . More soon.

@ystarr

This comment has been minimized.

Show comment
Hide comment
@ystarr

ystarr Jul 21, 2017

Contributor

@dblock @orta AT LAST, I've gone in and finally completed my review of this. Thank you HUGELY for your patience. I am now ready for you to review and commit my changes to the API!

Again, for full clarity, at this point in time, the API should return public domain works, no genome data, no commercial records (for e.g., gallery transactions, ownership or historical provenance), and no commercial inventory. And the API Terms are for non-commercial use by the user only.

Thank you to you both!!!

Contributor

ystarr commented Jul 21, 2017

@dblock @orta AT LAST, I've gone in and finally completed my review of this. Thank you HUGELY for your patience. I am now ready for you to review and commit my changes to the API!

Again, for full clarity, at this point in time, the API should return public domain works, no genome data, no commercial records (for e.g., gallery transactions, ownership or historical provenance), and no commercial inventory. And the API Terms are for non-commercial use by the user only.

Thank you to you both!!!

@orta

orta approved these changes Jul 21, 2017

@dblock

This comment has been minimized.

Show comment
Hide comment
@dblock

dblock Jul 24, 2017

Member

This is great, see my comment on two typos, otherwise ship it!

Member

dblock commented Jul 24, 2017

This is great, see my comment on two typos, otherwise ship it!

@ystarr

This comment has been minimized.

Show comment
Hide comment
@ystarr

ystarr Jul 24, 2017

Contributor

Thanks to all for their review...naive question -- what happens next?

Contributor

ystarr commented Jul 24, 2017

Thanks to all for their review...naive question -- what happens next?

@ystarr

This comment has been minimized.

Show comment
Hide comment
@ystarr

ystarr Jul 25, 2017

Contributor
Contributor

ystarr commented Jul 25, 2017

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jul 25, 2017

Member

👍 This looks good to go - shipping it, thanks for the PR @ystarr

🐰 💅

Member

orta commented Jul 25, 2017

👍 This looks good to go - shipping it, thanks for the PR @ystarr

🐰 💅

@orta orta merged commit 5a1f360 into artsy:master Jul 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment