New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Migrates to Moya 9 #669

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@ashfurrow
Member

ashfurrow commented Jul 5, 2017

This PR points our Moya dependency to this PR, a proposal in Moya to move to a more idiomatic way of accessing the Rx extension of Moya. I had some concerns about backwards compatibility and wanted to use Eidolon as a testbed to see how the migrate went.

Things went very smoothly. I had to add the headers property to my TargetTypes incidentally. The actual change for the PR involves the Networking.swift file. These changes modify how we customize the Rx extensions in Moya; specifically, our subclass has a provider now (instead of being a provider before). There were a few gotchas with the compiler so hopefully this PR will help someone else.

This is a WIP since Moya 9 isn't officially out yet.

Tests fail locally but this seems incidental to the Moya changes:

screen shot 2017-07-05 at 1 27 23 pm

@pedrovereza pedrovereza referenced this pull request Sep 16, 2017

Merged

Moya 9.0 migration #677

0 of 1 task complete
@ashfurrow

This comment has been minimized.

Show comment
Hide comment
@ashfurrow

ashfurrow Sep 21, 2017

Member

Closed by #677.

Member

ashfurrow commented Sep 21, 2017

Closed by #677.

@ashfurrow ashfurrow closed this Sep 21, 2017

@artsy-peril

This comment has been minimized.

Show comment
Hide comment
@artsy-peril

artsy-peril bot Sep 21, 2017

Warnings
⚠️

Please assign someone to merge this PR, and optionally include people who should review.

Generated by 🚫 dangerJS

artsy-peril bot commented Sep 21, 2017

Warnings
⚠️

Please assign someone to merge this PR, and optionally include people who should review.

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment