New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider enforcing testing on device #578

Closed
ashfurrow opened this Issue Jul 3, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@ashfurrow
Member

ashfurrow commented Jul 3, 2015

What do y'all think about having CI fail a PR if it doesn鈥檛 end with '馃摫'? That way ones with 馃毇馃摫 or 馃摫 would be OK, forcing the submitter to specify one way or the other?

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jul 3, 2015

Member

I had something similar in mind with this artsy/mobile#31 - might work on Circle, Travis didn't provide enough metadata to get back to the PR to make a call

Member

orta commented Jul 3, 2015

I had something similar in mind with this artsy/mobile#31 - might work on Circle, Travis didn't provide enough metadata to get back to the PR to make a call

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jan 11, 2016

Member

We got this #1013

Member

orta commented Jan 11, 2016

We got this #1013

@orta orta closed this Jan 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment