New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@alloy => Initial import of danger #1013

Merged
merged 1 commit into from Jan 7, 2016

Conversation

Projects
None yet
6 participants
@orta
Member

orta commented Jan 7, 2016

No description provided.

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jan 7, 2016

By analyzing the blame information on this pull request, we identified @ashfurrow to be a potential reviewer

mention-bot commented Jan 7, 2016

By analyzing the blame information on this pull request, we identified @ashfurrow to be a potential reviewer

Show outdated Hide outdated Dangerfile

@orta orta changed the title from [Danger] Initial import of danger to [WIP][Danger] Initial import of danger Jan 7, 2016

Show outdated Hide outdated Gemfile
@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jan 7, 2016

Member

OK, assuming this greens. I'm good for this.

Member

orta commented Jan 7, 2016

OK, assuming this greens. I'm good for this.

@orta orta changed the title from [WIP][Danger] Initial import of danger to @alloy => Initial import of danger Jan 7, 2016

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jan 7, 2016

Member

I'm happy for the Dangerfile to grow and evolve naturally, rather than try to anticipate all our plans.

Member

orta commented Jan 7, 2016

I'm happy for the Dangerfile to grow and evolve naturally, rather than try to anticipate all our plans.

@orta

This comment has been minimized.

Show comment
Hide comment
@orta
Member

orta commented Jan 7, 2016

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jan 7, 2016

Member

Oh yeah, needs a changelog entry, thanks Danger!

Member

orta commented Jan 7, 2016

Oh yeah, needs a changelog entry, thanks Danger!

@ArtsyOpenSource

This comment has been minimized.

Show comment
Hide comment
@ArtsyOpenSource

ArtsyOpenSource Jan 7, 2016

No errors found
  1 Warning
⚠️ Needs testing on a Phone if change is non-trivial

Generated by danger on 2016-01-07

ArtsyOpenSource commented Jan 7, 2016

No errors found
  1 Warning
⚠️ Needs testing on a Phone if change is non-trivial

Generated by danger on 2016-01-07

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jan 7, 2016

Member

:shipit:

Member

orta commented Jan 7, 2016

:shipit:

@alloy

This comment has been minimized.

Show comment
Hide comment
@alloy
Member

alloy commented Jan 7, 2016

alloy added a commit that referenced this pull request Jan 7, 2016

@alloy alloy merged commit 524382f into master Jan 7, 2016

2 checks passed

KrauseFx/danger ⚠️ danger found warnings, merge with caution
ci/circleci Your tests passed on CircleCI!
Details

@alloy alloy deleted the orta-dm branch Jan 7, 2016

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jan 7, 2016

Member

Great choice of GIFs.

Member

orta commented Jan 7, 2016

Great choice of GIFs.

@KrauseFx

This comment has been minimized.

Show comment
Hide comment
@KrauseFx

KrauseFx Jan 7, 2016

Contributor

So beautiful ❤️

Contributor

KrauseFx commented Jan 7, 2016

So beautiful ❤️

@alloy

This comment has been minimized.

Show comment
Hide comment
@alloy

alloy Jan 7, 2016

Member

Is quoting Austin Powers ever not a good idea?

Groovy, baby!

Member

alloy commented Jan 7, 2016

Is quoting Austin Powers ever not a good idea?

Groovy, baby!

@ashfurrow

This comment has been minimized.

Show comment
Hide comment
@ashfurrow

ashfurrow Jan 7, 2016

Member

I like this so much

Member

ashfurrow commented Jan 7, 2016

I like this so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment