From be502343a82102a739b33ecd36fde8b007fb8080 Mon Sep 17 00:00:00 2001 From: Mounir Dhahri Date: Wed, 22 May 2024 13:14:25 +0200 Subject: [PATCH 1/2] chore: enable new submission flow --- src/app/store/config/features.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/app/store/config/features.ts b/src/app/store/config/features.ts index b4d4b83e0fb..320fba080b5 100644 --- a/src/app/store/config/features.ts +++ b/src/app/store/config/features.ts @@ -272,8 +272,9 @@ export const features = { }, AREnableNewSubmissionFlow: { description: "Enable new submission flow", - readyForRelease: false, + readyForRelease: true, showInDevMenu: true, + echoFlagKey: "AREnableNewSubmissionFlow", }, AREnableSubmitMyCollectionArtworkInSubmitFlow: { description: "Enable Start Submission from My Collection in submit artwork flow", @@ -282,8 +283,9 @@ export const features = { }, AREnableSaveAndContinueSubmission: { description: "Enable save and continue submission flow", - readyForRelease: false, + readyForRelease: true, showInDevMenu: true, + echoFlagKey: "AREnableSaveAndContinueSubmission", }, } satisfies { [key: string]: FeatureDescriptor } From 775d09ea7ccb96f970c0266782f038f754dbfcd0 Mon Sep 17 00:00:00 2001 From: Mounir Dhahri Date: Thu, 6 Jun 2024 12:37:43 +0200 Subject: [PATCH 2/2] fix: broken tests --- .../Artwork/Components/MyCollectionWhySell.tests.tsx | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/app/Scenes/MyCollection/Screens/Artwork/Components/MyCollectionWhySell.tests.tsx b/src/app/Scenes/MyCollection/Screens/Artwork/Components/MyCollectionWhySell.tests.tsx index 72201f3187d..7c31432e994 100644 --- a/src/app/Scenes/MyCollection/Screens/Artwork/Components/MyCollectionWhySell.tests.tsx +++ b/src/app/Scenes/MyCollection/Screens/Artwork/Components/MyCollectionWhySell.tests.tsx @@ -1,6 +1,6 @@ import { fireEvent, screen } from "@testing-library/react-native" import { MyCollectionWhySellTestsQuery } from "__generated__/MyCollectionWhySellTestsQuery.graphql" -import { GlobalStore } from "app/store/GlobalStore" +import { GlobalStore, __globalStoreTestUtils__ } from "app/store/GlobalStore" import { navigate } from "app/system/navigation/navigate" import { flushPromiseQueue } from "app/utils/tests/flushPromiseQueue" import { mockTrackEvent } from "app/utils/tests/globallyMockedStuff" @@ -51,6 +51,9 @@ describe("MyCollectionWhySell", () => { // P1 related tests describe("Artwork without submission", () => { describe("Navigation", () => { + beforeEach(() => { + __globalStoreTestUtils__?.injectFeatureFlags({ AREnableNewSubmissionFlow: false }) + }) it("navigates to the sale form when Submit for Sale is pressed", () => { renderWithWrappers() @@ -62,6 +65,7 @@ describe("MyCollectionWhySell", () => { fireEvent.press(button) expect(navigate).toBeCalledWith("/sell/submissions/new") }) + it("navigates to the explanatory page when learn more is press", () => { renderWithWrappers() @@ -141,6 +145,9 @@ describe("MyCollectionWhySell", () => { }) describe("Behavior", () => { + beforeEach(() => { + __globalStoreTestUtils__?.injectFeatureFlags({ AREnableNewSubmissionFlow: false }) + }) it("initializes the submission form", async () => { renderWithWrappers() resolveData({