Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support code injection !m! #1236

Merged
merged 1 commit into from Mar 6, 2016

Conversation

@orta
Copy link
Contributor

commented Mar 5, 2016

OK - THIS IS AMAZING.

My compile & run cycle just went from (and I counted) 11 seconds to ~1 second.

Before we start, check out this GIF

2016-03-05 11_45_44

What is happening?

Injection: Dynamically re-compiles files you've saved, and ships those changes to your currently running app.

How does this work? In simple, it is an Xcode plugin that can compile your code into a bundle, this bundle is then added to your app. It will include newer versions of the classes you've injected via this bundle, then it is up to you to do something with this.

What does this PR do? So, the default behaviour of Injection is to allows re-compiled classes to know that they have been re-compiled. Given the viewDidLoad heavy view controllers we create I felt it would be better for our flow to work a little different from that.

Instead of letting the view controllers themselves act upon the injection, our top view controller is expanded to deal with the changes and adds some smart defaults. I've been recommending everyone use our developer extras to do their app cycle work: e,g,

- (void)runDeveloperExtras
{
    LiveAuctionViewController *liveVC = [[LiveAuctionViewController alloc] init];
    [self pushViewController:liveVC animated:YES];
}

I've expanded that to include a pop when injected, and to re-run the code inside developer extras. This means that the code inside runDeveloperExtras will be run on every injection. So you can keep working in the same file, constantly injecting new versions in again & again.

@mention-bot

This comment has been minimized.

Copy link

commented Mar 5, 2016

By analyzing the blame information on this pull request, we identified @ashfurrow to be a potential reviewer

@orta orta force-pushed the orta-INJECTION branch from 3026320 to e4cac5a Mar 5, 2016

@ArtsyOpenSource

This comment has been minimized.

Copy link

commented Mar 5, 2016

1 Error
🚫 Developer Specific file shouldn't be changed
1 Warning
⚠️

Found unstubbbed networking requests

Generated by 🚫 danger

@orta

This comment has been minimized.

Copy link
Contributor Author

commented Mar 5, 2016

This Danger fail is totally legit, however, I am very purposely editing this file. So we can consider it green.

@ashfurrow

This comment has been minimized.

Copy link
Member

commented Mar 6, 2016

👍🎉😻

ashfurrow added a commit that referenced this pull request Mar 6, 2016

Merge pull request #1236 from artsy/orta-INJECTION
Support code injection !m!

@ashfurrow ashfurrow merged commit f7bfbe4 into orta-live_networking Mar 6, 2016

1 check failed

ci/circleci Your tests failed on CircleCI
Details

@orta orta deleted the orta-INJECTION branch Mar 6, 2016

{
[self.rootNavigationController popViewControllerAnimated:NO];
[self runDeveloperExtras];
}

This comment has been minimized.

Copy link
@alloy

alloy Mar 8, 2016

Member

Cool 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.