New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default to BID for bid button txt in biddable sales #2659

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@erikdstock
Contributor

erikdstock commented Jul 5, 2018

Tracked in:
https://artsyproduct.atlassian.net/browse/PURCHASE-240 https://artsyproduct.atlassian.net/browse/PURCHASE-250

This updates the bid button messaging:

  • A few unchanged cases where the auction state or user's registration status is special (closed, reg pending etc)
  • All open sales say "Bid"
  • Upcoming sales show the user's registration status (green 'you are registered' box) or 'register to bid'

_regarding the 'register to bid' button, I believe the logic hinges on this bit:
https://github.com/artsy/eigen/blob/master/Artsy/Constants/ARAppConstants.h#L30
Which is new to me.

@erikdstock erikdstock requested a review from sweir27 Jul 5, 2018

} else if (state & ARAuctionStateUserIsRegistered) {
title = ARBidButtonRegisteredStateTitle;
// TODO: replace with a standard artsy color
backgroundColor = [UIColor colorWithHex:0x529900];
// don't want the 'disabled' flavor of the green color
enabled = YES;
interactionEnabled = NO;
// Sale is not open and user is not registered: "Register"
} else {
title = ARBidButtonRegisterStateTitle;

This comment has been minimized.

@sweir27

sweir27 Jul 5, 2018

Collaborator

If we want the user to be kicked into the register flow instead of the bid flow in this case, would that be a change on eigen's side or emission's?

This comment has been minimized.

@erikdstock

erikdstock Jul 5, 2018

Contributor

This would be eigen's responsibility, but could be a separate change (at least from the specific issue I'm addressing).

@erikdstock erikdstock force-pushed the erikdstock-PURCH-240-bid-button-txt branch from d327770 to a453811 Jul 11, 2018

@erikdstock

This comment has been minimized.

Contributor

erikdstock commented Jul 11, 2018

After generating snew snapshots I have realized that this button also appears in some auction registration contexts, like here when you go from the auction screen to the auction info screen (which has its own registration button)

Upon further inspection I have realized this bid button is also the registration button itself!
image

@erikdstock

This comment has been minimized.

Contributor

erikdstock commented Jul 13, 2018

Hi @ashfurrow - Perhaps we could talk about this remotely next week. I thought it was an easy fix but as I mentioned above it was not. Closing this PR for now.

@erikdstock erikdstock closed this Jul 13, 2018

@ashfurrow ashfurrow deleted the erikdstock-PURCH-240-bid-button-txt branch Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment