New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converts the main Dangerfile to be a Dangerfile.swift instead #2750

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@orta
Copy link
Member

orta commented Dec 19, 2018

This switches the main Eigen run of Danger to use Danger.swift instead of running on good ole Ruby Danger.

I directly ported all of the rules but one, a check to see if the submodule commit exists in the eigen-artefacts repo. For now the GitHub API is pretty limited in Danger Swift, but there are ideas on how to improve that.

screen shot 2018-12-19 at 3 18 39 pm

#trivial

@orta orta force-pushed the orta-danger-swift branch 3 times, most recently from d45ff93 to a553a56 Dec 19, 2018

@orta orta force-pushed the orta-danger-swift branch from a553a56 to a7beea6 Dec 27, 2018

@ashfurrow
Copy link
Member

ashfurrow left a comment

Sweet!

@ashfurrow ashfurrow merged commit 82e81f3 into master Jan 3, 2019

3 checks passed

Peril All green. Good on 'ya.
Details
ci/circleci: build-and-test Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ashfurrow ashfurrow deleted the orta-danger-swift branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment