Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MX-2] Deletes unused code, cleans up deprecation warnings, removes old Echo flags #3017

Merged
merged 14 commits into from Feb 10, 2020

Conversation

@ashfurrow
Copy link
Member

ashfurrow commented Feb 7, 2020

This pull request is housecleaning for Eigen. Sorry for the huge PR, but since it's mostly deletions, it didn't make sense to me to split it up.

Overall, the number of native unit tests dropped from 911 to 801. With far less code, I expect to see significantly improved compile times locally for developers, as well as on CI. Users will also see a smaller app download size. A win-win-win 🎉

Here's a high-level summary:

  • Removes a lot of classes that weren't being used anymore (examples: old Search, old Artwork utility views, old (pre-2016) home feed views, quicksilver integration for devs to navigate around that was unused, etc)
  • Cleans up Echo flags, see MX-2. This includes the Search flag – it's been three weeks since launch and if something did go wrong at this point, I'd expect we'd submit an expedited review request rather than go back to the old native search.
  • Cleans up some deprecation warnings, see MX-119 (the remaining ones will be tough). I ignored a few, since that logic will be moved into React Native soon enough anyway (and migrating to the new APIs was nontrivial).
@ashfurrow

This comment has been minimized.

Copy link
Member Author

ashfurrow commented Feb 7, 2020

Nice, this shaved more than a minute off of Eigen's CI time!

@ds300
ds300 approved these changes Feb 10, 2020
Copy link
Contributor

ds300 left a comment

AMAZING

@ds300 ds300 merged commit 387c86b into master Feb 10, 2020
3 checks passed
3 checks passed
Peril All green. Good on 'ya.
Details
ci/circleci: build-and-test Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ds300 ds300 deleted the ashfurrow-lets-delete-a-lot-of-code branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.