Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Changelog parse error #trivial #3961

Merged
merged 1 commit into from Oct 2, 2020
Merged

Conversation

ashfurrow
Copy link
Contributor

@ashfurrow ashfurrow commented Oct 2, 2020

The type of this PR is: bugfix

Description

This was failing to parse in our Fastfile with the following error:

Psych::SyntaxError: (<unknown>): found character that cannot start any token while scanning for the next token at line 19 column 7

This caused the beta deploy to fail.

/cc @sepans

PR Checklist (tick all before merging)

  • I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added an app state migration, or my changes do not require one. (What are migrations?)
  • I have added a CHANGELOG.yml entry or my changes do not require one.

This was failing to parse in our `Fastfile` with the following error:

```
Psych::SyntaxError: (<unknown>): found character that cannot start any token while scanning for the next token at line 19 column 7
```
@ashfurrow ashfurrow added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Oct 2, 2020
@ashfurrow ashfurrow self-assigned this Oct 2, 2020
@artsy-peril artsy-peril bot merged commit 320bf7c into master Oct 2, 2020
@artsy-peril artsy-peril bot deleted the ashfurrow-patch-1 branch October 2, 2020 15:32
@sepans
Copy link
Contributor

sepans commented Oct 2, 2020

Thanks for the fix 🙏. Sorry about that

@ashfurrow
Copy link
Contributor Author

No worries at all! We actually have tooling to check this on PRs:

eigen/dangerfile.ts

Lines 100 to 101 in 320bf7c

const changelogYML = fs.readFileSync("CHANGELOG.yml").toString()
const loadedDictionary = yaml.parse(changelogYML)

But this error is specific to the Ruby library we use in the Fastfile 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Synced Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants