New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@ashfurrow => Route to /auction/ when tapping on a bid button #534

Merged
merged 2 commits into from Jun 25, 2015

Conversation

Projects
None yet
3 participants
@orta
Member

orta commented Jun 22, 2015

Fixes: #529

@orta orta changed the title from Route to /auction/ when tapping on a bid button to @ashfurrow => Route to /auction/ when tapping on a bid button Jun 22, 2015

@orta orta referenced this pull request Jun 22, 2015

Closed

Bidding is not working #529

@ashfurrow

This comment has been minimized.

Show comment
Hide comment
@ashfurrow

ashfurrow Jun 24, 2015

Member

Sorry I missed this – it needs a rebase.

Member

ashfurrow commented Jun 24, 2015

Sorry I missed this – it needs a rebase.

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jun 25, 2015

Member

done'd

Member

orta commented Jun 25, 2015

done'd

Show outdated Hide outdated Artsy.xcodeproj/xcshareddata/xcschemes/Artsy.xcscheme
BlueprintIdentifier = "7B6F3179CDD265E55DF25EFE"
BuildableName = "libPods.a"
BlueprintIdentifier = "7B290E9A1822F602465768A6"
BuildableName = "Pods.framework"

This comment has been minimized.

@alloy

alloy Jun 25, 2015

Member

Where does this framework reference come from?

@alloy

alloy Jun 25, 2015

Member

Where does this framework reference come from?

This comment has been minimized.

@orta

orta Jun 25, 2015

Member

oh, sneakyyyyyyy, must have come in from me working on a frameworks branch

@orta

orta Jun 25, 2015

Member

oh, sneakyyyyyyy, must have come in from me working on a frameworks branch

This comment has been minimized.

@alloy

alloy Jun 25, 2015

Member

Ok ok, so I’m not going crazy, at least not that crazy 😄

@alloy

alloy Jun 25, 2015

Member

Ok ok, so I’m not going crazy, at least not that crazy 😄

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jun 25, 2015

Member

Removed the sneaky Pods.framework ref

Member

orta commented Jun 25, 2015

Removed the sneaky Pods.framework ref

ashfurrow added a commit that referenced this pull request Jun 25, 2015

Merge pull request #534 from artsy/orta-route_auction
@ashfurrow => Route to /auction/ when tapping on a bid button

@ashfurrow ashfurrow merged commit 727983f into master Jun 25, 2015

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@@ -182,7 +182,7 @@ - (ARArtworkSetViewController *)loadArtworkSet:(NSArray *)artworkSet inFair:(Fai
- (UIViewController *)loadBidUIForArtwork:(NSString *)artworkID inSale:(NSString *)saleID
{
NSString *path = [NSString stringWithFormat:@"/feature/%@/bid/%@", saleID, artworkID];
NSString *path = [NSString stringWithFormat:@"/auctions/%@/bid/%@", saleID, artworkID];

This comment has been minimized.

@orta

orta Jun 29, 2015

Member

this needs changing to /auction/ - artsy doesn't do the rails-y routing :-/

@orta

orta Jun 29, 2015

Member

this needs changing to /auction/ - artsy doesn't do the rails-y routing :-/

This comment has been minimized.

@ashfurrow

ashfurrow Jun 29, 2015

Member

Gotcha. Let me know @alloy if you want me to fix that.

@ashfurrow

ashfurrow Jun 29, 2015

Member

Gotcha. Let me know @alloy if you want me to fix that.

This comment has been minimized.

@alloy

alloy Jun 29, 2015

Member

@ashfurrow Did done: #558.

This comment has been minimized.

@ashfurrow

ashfurrow Jun 29, 2015

Member

🎉

@alloy alloy referenced this pull request Jun 29, 2015

Closed

Fix auction bid route. #558

@alloy alloy deleted the orta-route_auction branch Sep 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment