Play and summarize Artsy podcasts. #56

Merged
merged 1 commit into from Feb 8, 2017

Conversation

Projects
None yet
3 participants
@dblock
Member

dblock commented Feb 7, 2017

Closes #51.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 7, 2017

Coverage Status

Coverage decreased (-8.6%) to 75.92% when pulling 0e32e06 on dblock:podcasts into 372f9cd on artsy:master.

Coverage Status

Coverage decreased (-8.6%) to 75.92% when pulling 0e32e06 on dblock:podcasts into 372f9cd on artsy:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 7, 2017

Coverage Status

Coverage increased (+1.5%) to 85.953% when pulling 0e32e06 on dblock:podcasts into 372f9cd on artsy:master.

coveralls commented Feb 7, 2017

Coverage Status

Coverage increased (+1.5%) to 85.953% when pulling 0e32e06 on dblock:podcasts into 372f9cd on artsy:master.

@dblock dblock referenced this pull request in alexa-js/alexa-app Feb 7, 2017

Merged

AudioPlayer functionality (Continue PR #88) #92

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Feb 7, 2017

Coverage Status

Coverage increased (+1.5%) to 85.953% when pulling 9e15972 on dblock:podcasts into 372f9cd on artsy:master.

Coverage Status

Coverage increased (+1.5%) to 85.953% when pulling 9e15972 on dblock:podcasts into 372f9cd on artsy:master.

@ashkan18

Super cooooool!

+ token: streamUrl,
+ offsetInMilliseconds: 0
+ }
+ res.audioPlayerPlayStream('REPLACE_ALL', stream);

This comment has been minimized.

@ashkan18

ashkan18 Feb 7, 2017

Collaborator

magic?! Need to read about audoPlayerPlayStream

@ashkan18

ashkan18 Feb 7, 2017

Collaborator

magic?! Need to read about audoPlayerPlayStream

This comment has been minimized.

@dblock

dblock Feb 8, 2017

Member

Yes, this is a "native" function of the API of alexa-app, see https://github.com/alexa-js/alexa-app

@dblock

dblock Feb 8, 2017

Member

Yes, this is a "native" function of the API of alexa-app, see https://github.com/alexa-js/alexa-app

+_.mixin(require('underscore.string').exports());
+
+function Podcast() {
+ this.rssUrl = 'https://feeds.soundcloud.com/users/soundcloud:users:211089382/sounds.rss';

This comment has been minimized.

@ashkan18

ashkan18 Feb 7, 2017

Collaborator

I was going to suggest make this an env but I guess there is no point if we lose env everytime we deploy.

@ashkan18

ashkan18 Feb 7, 2017

Collaborator

I was going to suggest make this an env but I guess there is no point if we lose env everytime we deploy.

This comment has been minimized.

@dblock

dblock Feb 8, 2017

Member

Yeah, and it's not likely to change without having to do code changes.

@dblock

dblock Feb 8, 2017

Member

Yeah, and it's not likely to change without having to do code changes.

@dblock dblock merged commit abc9ee6 into artsy:master Feb 8, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.5%) to 85.953%
Details

@dblock dblock deleted the dblock:podcasts branch Feb 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment